Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13782: Fix false negative for annotation indentation #14149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@kalpadiptyaroy
Copy link
Contributor Author

Hi. @romani. I have taken up this issue.
I have setup a test case following the sample code in the issue description. Can you kindly confirm .. if I have going in the correct way?

@romani
Copy link
Member

romani commented Dec 18, 2023

Yes, you are right.
If you make CI green, we can merge test creation (this PR) before actual fix, so we will update issue description to mention that special test needs to be updated to reproduce issue in debug easily.
It will make actual fix PR smaller, so easer to review.

@kalpadiptyaroy kalpadiptyaroy force-pushed the false-negative-annot-indent branch 20 times, most recently from 3cb9187 to 1ad56b0 Compare December 23, 2023 18:46
@kalpadiptyaroy
Copy link
Contributor Author

@nrmancuso
Copy link
Member

nrmancuso commented Dec 23, 2023

@romani - can you guide me how to fix this problem?

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/22461/workflows/591057a6-c1e6-415f-86a3-8ccea621daad/jobs/456518?invite=true#step-103-30024_119

These are checkstyle violations on the code in this PR, please fix them and examine and fix mvn clean verify failures as well.

We will also need to generate a check regression report, please see https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#executing-generation for details, and use check module from issue.

@kalpadiptyaroy kalpadiptyaroy force-pushed the false-negative-annot-indent branch 5 times, most recently from b0100d9 to 950d327 Compare December 26, 2023 14:35
@kalpadiptyaroy
Copy link
Contributor Author

GitHub, generate report

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/8132494391

@kalpadiptyaroy
Copy link
Contributor Author

@nrmancuso. Hi Nick. The report generation is failing for openjdk17, with reason OutOfMemoryException.

I need help on this!
Let me know what I should do? Also consider having a look in my gist config xml file, where I have updated the Indentation check module with its properties.

@nrmancuso
Copy link
Member

@kalpadiptyaroy it is probably from a massive difference in violations. I would suggest to create your own projects file with openjdk17 removed

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 4, 2024

Ok. I will try that. But do I need to do it on my local or is it possible to modify projects file on github?

@nrmancuso
Copy link
Member

https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-difference-report-with-custom-projects-list

@kalpadiptyaroy
Copy link
Contributor Author

GitHub, generate report

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/8136304896

@kalpadiptyaroy
Copy link
Contributor Author

GitHub, generate report

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 4, 2024

@nrmancuso. without openjdk17- report is generated! Have a look

I will try to generate the report for openjdk17 in my local as well, in the meantime - since I have a good amount of RAM
and let you know.

@nrmancuso
Copy link
Member

@nrmancuso. without openjdk17- report is generated! Have a look

I will try to generate the report for openjdk17 in my local as well, in the meantime - since I have a good amount of RAM and let you know.

You can try to generate the report via GitHub action with only OpenJdk and see how that goes

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 4, 2024

You can try to generate the report via GitHub action with only OpenJdk and see how that goes

@nrmancuso - sure will do that as well. But what about the report that is last generated? is it good ? and can we proceed with the PR?

@kalpadiptyaroy
Copy link
Contributor Author

GitHub, generate report

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/8157232565

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 5, 2024

@nrmancuso - Tried to generate the regression report only for openjdk17. But still it failed with OutOfMemoryException.

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 5, 2024

@nrmancuso - Tried to generate the regression report only for openjdk17 on my local. This time its not OutOfMemoryException, but some other error (not clear to me).

These are logs for the same on my local.

openjdk17 Logs in Local - For Diff-Report
  PS D:\opensource\project-checkstyle\contribution\checkstyle-tester> groovy diff.groovy -r D:\opensource\project-checkstyle\checkstyle -b master -p false-negative-annot-indent -bc my-checks.xml -pc my-checks.xml -l my-projects-to-test-on.properties
     [delete] Deleting directory D:\opensource\project-checkstyle\contribution\checkstyle-tester\reports
  Installing Checkstyle artifact (master) into local Maven repository ...
  Running command: git checkout master
  Already on 'master'Your branch is behind 'origin/master' by 16 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
  Running command: git log -1 --pretty=MSG:%s%nSHA-1:%H
  MSG:minor: fix link to avoid redirection (link-check-plugin)
  SHA-1:ccde012394294f31d1cc28c51e03c6a622424663
  Running command: mvn -e --no-transfer-progress --batch-mode -Pno-validations clean install
  [INFO] Error stacktraces are turned on.
  [INFO] Scanning for projects...
  [INFO] Inspecting build with total of 1 modules...
  [INFO] Installing Nexus Staging features:
  [INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
  [INFO]
  [INFO] ------------------< com.puppycrawl.tools:checkstyle >-------------------
  [INFO] Building checkstyle 10.14.0-SNAPSHOT
  [INFO]   from pom.xml
  [INFO] --------------------------------[ jar ]---------------------------------
  [INFO]
  [INFO] --- clean:3.3.2:clean (default-clean) @ checkstyle ---
  [INFO] Deleting D:\opensource\project-checkstyle\checkstyle\target
  [INFO]
  [INFO] --- tidy:1.2.0:check (validate) @ checkstyle ---
  [INFO] Tidy is skipped.
  [INFO]
  [INFO] --- enforcer:3.4.1:enforce (enforce-maven) @ checkstyle ---
  [INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
  [INFO]
  [INFO] --- enforcer:3.4.1:enforce (enforce-versions) @ checkstyle ---
  [INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
  [INFO] Rule 1: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
  [INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.DependencyConvergence passed
  [INFO]
  [INFO] --- xml:1.1.0:check-format (default) @ checkstyle ---
  [INFO]
  [INFO] --- antlr4:4.13.1:antlr4 (default) @ checkstyle ---
  [INFO] ANTLR 4: Processing source directory D:\opensource\project-checkstyle\checkstyle\src\main\resources
  [INFO] Processing grammar: com\puppycrawl\tools\checkstyle\grammar\java\JavaLanguageLexer.g4
  [INFO] Processing grammar: com\puppycrawl\tools\checkstyle\grammar\java\JavaLanguageParser.g4
  [INFO] Processing grammar: com\puppycrawl\tools\checkstyle\grammar\javadoc\JavadocLexer.g4
  [INFO] Processing grammar: com\puppycrawl\tools\checkstyle\grammar\javadoc\JavadocParser.g4
  [INFO]
  [INFO] --- build-helper:3.5.0:add-source (add-source) @ checkstyle ---
  [INFO] Source directory: D:\opensource\project-checkstyle\checkstyle\target\generated-sources\antlr added.
  [INFO]
  [INFO] --- resources:3.3.1:resources (default-resources) @ checkstyle ---
  [INFO] Copying 395 resources from src\main\resources to target\classes
  [INFO]
  [INFO] --- build-helper:3.5.0:add-test-source (add-test-source) @ checkstyle ---
  [INFO] Test Source directory: D:\opensource\project-checkstyle\checkstyle\src\test\resources added.
  [INFO]
  [INFO] --- build-helper:3.5.0:add-test-source (add-it-test-source) @ checkstyle ---
  [INFO] Test Source directory: D:\opensource\project-checkstyle\checkstyle\src\it\java added.
  [INFO]
  [INFO] --- build-helper:3.5.0:add-test-source (add-it-test-resource) @ checkstyle ---
  [INFO] Test Source directory: D:\opensource\project-checkstyle\checkstyle\src\it\resources added.
  [INFO]
  [INFO] --- build-helper:3.5.0:add-test-source (add-xdocs-examples-source) @ checkstyle ---
  [INFO] Test Source directory: D:\opensource\project-checkstyle\checkstyle\src\xdocs-examples\java added.
  [INFO]
  [INFO] --- build-helper:3.5.0:add-test-source (add-xdocs-examples-resource) @ checkstyle ---
  [INFO] Test Source directory: D:\opensource\project-checkstyle\checkstyle\src\xdocs-examples\resources added.
  [INFO]
  [INFO] --- compiler:3.12.1:compile (default-compile) @ checkstyle ---
  [INFO] Recompiling the module because of changed source code.
  [INFO] Compiling 448 source files with javac [debug release 11] to target\classes
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/XMLLogger.java: Some input files use or override a deprecated API.
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/XMLLogger.java: Recompile with -Xlint:deprecation for details.
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/AbstractAutomaticBean.java: D:\opensource\project-checkstyle\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\AbstractAutomaticBean.java uses unchecked or unsafe operations.
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/AbstractAutomaticBean.java: Recompile with -Xlint:unchecked for details.
  [INFO]
  [INFO] --- plexus-component-metadata:2.2.0:generate-metadata (default) @ checkstyle ---
  [INFO] Discovered 6 component descriptor(s)
  [INFO]
  [INFO] --- exec:3.2.0:java (default) @ checkstyle ---
  [INFO]
  [INFO] --- resources:3.3.1:testResources (default-testResources) @ checkstyle ---
  [INFO] Copying 2705 resources from src\test\resources to target\test-classes
  [INFO]
  [INFO] --- compiler:3.12.1:testCompile (default-testCompile) @ checkstyle ---
  [INFO] Recompiling the module because of changed dependency.
  [INFO] Compiling 3778 source files with javac [debug release 11] to target\test-classes
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionTrickyYield.java:[8,16] 'yield' may become a restricted identifier in a future release
    (to invoke a method called yield, qualify the yield with a receiver or type name)
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/imports/avoidstaticimport/InputAvoidStaticImportDefault.java:[112,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect3.java:[42,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect3.java:[63,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect3.java:[25,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedSpecialCase.java:[21,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedSpecialCase.java:[26,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedSpecialCase.java:[99,11] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedSpecialCase.java:[106,11] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedSpecialCase.java:[113,22] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck1.java:[43,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck1.java:[72,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck1.java:[97,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck1.java:[14,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocmissingleadingasterisk/InputJavadocMissingLeadingAsteriskIncorrect.java:[27,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocmissingleadingasterisk/InputJavadocMissingLeadingAsteriskIncorrect.java:[65,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderWithAnnotationsOutsideJavadoc.java:[36,20] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderWithAnnotationsOutsideJavadoc.java:[78,20] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/imports/avoidstarimport/InputAvoidStarImportDefault.java:[111,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck2.java:[28,10] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck2.java:[61,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck2.java:[87,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck2.java:[14,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck2.java:[108,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom1.java:[52,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom1.java:[79,10] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom1.java:[96,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom1.java:[110,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom1.java:[24,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputNonEmptyAtclauseDescriptionCheckSpaceSeq.java:[20,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputNonEmptyAtclauseDescriptionCheckSpaceSeq.java:[42,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionTwo.java:[26,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionTwo.java:[40,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionOne.java:[29,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionOne.java:[55,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionOne.java:[69,20] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionOne.java:[101,20] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionAnnotationOnSameLine2.java:[8,20] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionAnnotationOnSameLine2.java:[13,21] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionAnnotationOnSameLine2.java:[86,15] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionAnnotationOnSameLine2.java:[93,15] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/antlr4/InputAntlr4AstRegressionAnnotationOnSameLine2.java:[100,26] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect2.java:[33,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect2.java:[65,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/metrics/booleanexpressioncomplexity/InputBooleanExpressionComplexitySmall.java:[16,54] non-varargs call of varargs method with inexact argument type for last parameter;
    cast to java.lang.Class for a varargs call
    cast to java.lang.Class[] for a non-varargs call and to suppress this warning
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/metrics/booleanexpressioncomplexity/InputBooleanExpressionComplexitySmall.java:[18,46] non-varargs call of varargs method with inexact argument type for last parameter;
    cast to java.lang.Object for a varargs call
    cast to java.lang.Object[] for a non-varargs call and to suppress this warning
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/imports/avoidstarimport/InputAvoidStarImportAllowStaticMember.java:[111,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationChainedMethods.java:[10,13] non-varargs call of varargs method with inexact argument type for last parameter;
    cast to java.lang.Object for a varargs call
    cast to java.lang.Object[] for a non-varargs call and to suppress this warning
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/imports/unusedimports/InputUnusedImports2.java:[114,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck1.java:[42,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck1.java:[76,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck1.java:[103,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputIncorrectAtClauseOrderCheck1.java:[14,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationTryWithResourcesStrict.java:[59,69] non-varargs call of varargs method with inexact argument type for last parameter;
    cast to java.nio.file.OpenOption for a varargs call
    cast to java.nio.file.OpenOption[] for a non-varargs call and to suppress this warning
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadoctagcontinuationindentation/InputJavadocTagContinuationIndentationOffset3.java:[23,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedMethod.java:[18,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedClass.java:[19,8] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrder1.java:[23,8] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect1.java:[53,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect1.java:[82,10] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect1.java:[101,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect1.java:[115,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect1.java:[25,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/imports/unusedimports/InputUnusedImports.java:[114,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom2.java:[43,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom2.java:[78,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom2.java:[24,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect1.java:[53,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect1.java:[82,10] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect1.java:[100,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect1.java:[115,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrect1.java:[25,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[19,15] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[26,19] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[38,9] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[33,5] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[14,8] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[50,5] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[45,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[63,9] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/annotation/missingdeprecated/InputMissingDeprecatedBadDeprecated.java:[58,2] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect4.java:[33,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect4.java:[47,17] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect4.java:[58,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect4.java:[72,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect4.java:[88,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderCorrect4.java:[99,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom3.java:[41,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom3.java:[62,14] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/atclauseorder/InputAtclauseOrderIncorrectCustom3.java:[24,1] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/design/designforextension/InputDesignForExtensionIgnoredAnnotations.java:[176,11] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputNonEmptyAtclauseDescriptionCheck.java:[14,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputNonEmptyAtclauseDescriptionCheck.java:[41,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputNonEmptyAtclauseDescriptionCheck.java:[54,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck3.java:[23,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck3.java:[37,12] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck3.java:[57,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck3.java:[71,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck3.java:[85,16] deprecated item is not annotated with @Deprecated
  [WARNING] /D:/opensource/project-checkstyle/checkstyle/src/it/resources/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/InputCorrectAtClauseOrderCheck3.java:[99,16] deprecated item is not annotated with @Deprecated
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic14.java: Some input files use or override a deprecated API.
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic14.java: Recompile with -Xlint:deprecation for details.
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/TestUtil.java: Some input files use unchecked or unsafe operations.
  [INFO] /D:/opensource/project-checkstyle/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/TestUtil.java: Recompile with -Xlint:unchecked for details.
  [INFO]
  [INFO] --- jacoco:0.8.11:instrument (default-instrument) @ checkstyle ---
  [INFO] Skipping JaCoCo execution because property jacoco.skip is set.
  [INFO]
  [INFO] --- surefire:3.2.5:test (default-test) @ checkstyle ---
  [INFO] Tests are skipped.
  [INFO]
  [INFO] --- xml:1.1.0:validate (default) @ checkstyle ---
  [INFO]
  [INFO] --- jacoco:0.8.11:restore-instrumented-classes (default-restore-instrumented-classes) @ checkstyle ---
  [INFO] Skipping JaCoCo execution because property jacoco.skip is set.
  [INFO]
  [INFO] --- jar:3.3.0:jar (default-jar) @ checkstyle ---
  [INFO] Building jar: D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT.jar
  [INFO]
  [INFO] --- jar:3.3.0:test-jar (default) @ checkstyle ---
  [INFO] Building jar: D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT-tests.jar
  [INFO]
  [INFO] >>> source:3.3.0:test-jar (attach-sources) > generate-sources @ checkstyle >>>
  [INFO]
  [INFO] --- tidy:1.2.0:check (validate) @ checkstyle ---
  [INFO] Tidy is skipped.
  [INFO]
  [INFO] --- enforcer:3.4.1:enforce (enforce-maven) @ checkstyle ---
  [INFO]
  [INFO] --- enforcer:3.4.1:enforce (enforce-versions) @ checkstyle ---
  [INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.DependencyConvergence passed
  [INFO]
  [INFO] --- xml:1.1.0:check-format (default) @ checkstyle ---
  [INFO]
  [INFO] --- antlr4:4.13.1:antlr4 (default) @ checkstyle ---
  [INFO] No grammars to process
  [INFO] ANTLR 4: Processing source directory D:\opensource\project-checkstyle\checkstyle\src\main\resources
  [INFO]
  [INFO] --- build-helper:3.5.0:add-source (add-source) @ checkstyle ---
  [INFO] Source directory: D:\opensource\project-checkstyle\checkstyle\target\generated-sources\antlr added.
  [INFO]
  [INFO] <<< source:3.3.0:test-jar (attach-sources) < generate-sources @ checkstyle <<<
  [INFO]
  [INFO]
  [INFO] --- source:3.3.0:test-jar (attach-sources) @ checkstyle ---
  [INFO] Building jar: D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT-test-sources.jar
  [INFO]
  [INFO] >>> source:3.3.0:jar (attach-sources) > generate-sources @ checkstyle >>>
  [INFO]
  [INFO] --- tidy:1.2.0:check (validate) @ checkstyle ---
  [INFO] Tidy is skipped.
  [INFO]
  [INFO] --- enforcer:3.4.1:enforce (enforce-maven) @ checkstyle ---
  [INFO]
  [INFO] --- enforcer:3.4.1:enforce (enforce-versions) @ checkstyle ---
  [INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.DependencyConvergence passed
  [INFO]
  [INFO] --- xml:1.1.0:check-format (default) @ checkstyle ---
  [INFO]
  [INFO] --- antlr4:4.13.1:antlr4 (default) @ checkstyle ---
  [INFO] No grammars to process
  [INFO] ANTLR 4: Processing source directory D:\opensource\project-checkstyle\checkstyle\src\main\resources
  [INFO]
  [INFO] --- build-helper:3.5.0:add-source (add-source) @ checkstyle ---
  [INFO] Source directory: D:\opensource\project-checkstyle\checkstyle\target\generated-sources\antlr added.
  [INFO]
  [INFO] <<< source:3.3.0:jar (attach-sources) < generate-sources @ checkstyle <<<
  [INFO]
  [INFO]
  [INFO] --- source:3.3.0:jar (attach-sources) @ checkstyle ---
  [INFO] Building jar: D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT-sources.jar
  [INFO]
  [INFO] --- failsafe:3.2.5:integration-test (integration-test) @ checkstyle ---
  [INFO] Tests are skipped.
  [INFO]
  [INFO] --- modernizer:2.7.0:modernizer (modernizer) @ checkstyle ---
  [INFO] Skipping modernizer execution!
  [INFO]
  [INFO] --- jacoco:0.8.11:check (default-check) @ checkstyle ---
  [INFO] Skipping JaCoCo execution because property jacoco.skip is set.
  [INFO]
  [INFO] --- failsafe:3.2.5:verify (verify) @ checkstyle ---
  [INFO] Tests are skipped.
  [INFO]
  [INFO] --- antrun:3.1.0:run (ant-phase-verify) @ checkstyle ---
  [INFO] Executing tasks
  [INFO] Executed tasks
  [INFO]
  [INFO] >>> pmd:3.21.2:check (default) > :pmd @ checkstyle >>>
  [INFO]
  [INFO] --- pmd:3.21.2:pmd (pmd) @ checkstyle ---
  [INFO] Skipping PMD execution
  [INFO]
  [INFO] <<< pmd:3.21.2:check (default) < :pmd @ checkstyle <<<
  [INFO]
  [INFO]
  [INFO] --- pmd:3.21.2:check (default) @ checkstyle ---
  [INFO] Skipping PMD execution
  [INFO]
  [INFO] >>> spotbugs:4.8.3.1:check (default) > :spotbugs @ checkstyle >>>
  [INFO]
  [INFO] --- spotbugs:4.8.3.1:spotbugs (spotbugs) @ checkstyle ---
  [INFO]
  [INFO] <<< spotbugs:4.8.3.1:check (default) < :spotbugs @ checkstyle <<<
  [INFO]
  [INFO]
  [INFO] --- spotbugs:4.8.3.1:check (default) @ checkstyle ---
  [INFO] Spotbugs plugin skipped
  [INFO]
  [INFO] --- forbiddenapis:3.6:check (forbiddenapis-main) @ checkstyle ---
  [INFO] Skipping forbidden-apis checks.
  [INFO]
  [INFO] --- forbiddenapis:3.6:testCheck (forbiddenapis-test) @ checkstyle ---
  [INFO] Skipping forbidden-apis checks.
  [INFO]
  [INFO] --- install:3.1.1:install (default-install) @ checkstyle ---
  [INFO] Installing D:\opensource\project-checkstyle\checkstyle\pom.xml to C:\Users\DELL\.m2\repository\com\puppycrawl\tools\checkstyle\10.14.0-SNAPSHOT\checkstyle-10.14.0-SNAPSHOT.pom
  [INFO] Installing D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT.jar to C:\Users\DELL\.m2\repository\com\puppycrawl\tools\checkstyle\10.14.0-SNAPSHOT\checkstyle-10.14.0-SNAPSHOT.jar
  [INFO] Installing D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT-tests.jar to C:\Users\DELL\.m2\repository\com\puppycrawl\tools\checkstyle\10.14.0-SNAPSHOT\checkstyle-10.14.0-SNAPSHOT-tests.jar
  [INFO] Installing D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT-test-sources.jar to C:\Users\DELL\.m2\repository\com\puppycrawl\tools\checkstyle\10.14.0-SNAPSHOT\checkstyle-10.14.0-SNAPSHOT-test-sources.jar
  [INFO] Installing D:\opensource\project-checkstyle\checkstyle\target\checkstyle-10.14.0-SNAPSHOT-sources.jar to C:\Users\DELL\.m2\repository\com\puppycrawl\tools\checkstyle\10.14.0-SNAPSHOT\checkstyle-10.14.0-SNAPSHOT-sources.jar
  [INFO] ------------------------------------------------------------------------
  [INFO] BUILD SUCCESS
  [INFO] ------------------------------------------------------------------------
  [INFO] Total time:  03:33 min
  [INFO] Finished at: 2024-03-05T18:37:52+05:30
  [INFO] ------------------------------------------------------------------------
  [WARNING]
  [WARNING] Plugin validation issues were detected in 2 plugin(s)
  [WARNING]
  [WARNING]  * org.apache.maven.plugins:maven-pmd-plugin:3.21.2
  [WARNING]  * org.antlr:antlr4-maven-plugin:4.13.1
  [WARNING]
  [WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
  [WARNING]
  Testing Checkstyle started
     [delete] Deleting directory D:\opensource\project-checkstyle\contribution\checkstyle-tester\src\main\java
  openjdk17 is synchronized
       [copy] Copying 63754 files to D:\opensource\project-checkstyle\contribution\checkstyle-tester\src\main\java\openjdk17
  Running 'mvn clean' on src\main\java ...
  Running command: mvn -e --no-transfer-progress --batch-mode clean
  [INFO] Error stacktraces are turned on.
  [INFO] Scanning for projects...
  [INFO]
  [INFO] ----------------< com.github.sevntu.checkstyle:sample >-----------------
  [INFO] Building sample 0.0.1-SNAPSHOT
  [INFO]   from pom.xml
  [INFO] --------------------------------[ jar ]---------------------------------
  [INFO]
  [INFO] --- clean:3.2.0:clean (default-clean) @ sample ---
  [INFO] Deleting D:\opensource\project-checkstyle\contribution\checkstyle-tester\target
  Running Checkstyle on src\main\java ... with excludes {}
  [INFO] ------------------------------------------------------------------------
  [INFO] BUILD SUCCESS
  [INFO] ------------------------------------------------------------------------
  [INFO] Total time:  0.816 s
  [INFO] Finished at: 2024-03-05T18:51:58+05:30
  [INFO] ------------------------------------------------------------------------
  mvn -e --no-transfer-progress --batch-mode site -Dcheckstyle.config.location=my-checks.xml -Dcheckstyle.excludes= -Dcheckstyle.version=10.14.0-SNAPSHOT
  Running command: mvn -e --no-transfer-progress --batch-mode site -Dcheckstyle.config.location=my-checks.xml -Dcheckstyle.excludes= -Dcheckstyle.version=10.14.0-SNAPSHOT
  [INFO] Error stacktraces are turned on.
  [INFO] Scanning for projects...
  [INFO]
  [INFO] ----------------< com.github.sevntu.checkstyle:sample >-----------------
  [INFO] Building sample 0.0.1-SNAPSHOT
  [INFO]   from pom.xml
  [INFO] --------------------------------[ jar ]---------------------------------
  [INFO]
  [INFO] --- site:3.12.1:site (default-site) @ sample ---
  [INFO] configuring report plugin org.apache.maven.plugins:maven-site-plugin:3.3
  [INFO] configuring report plugin org.apache.maven.plugins:maven-project-info-reports-plugin:2.7
  [INFO] 15 reports detected for maven-project-info-reports-plugin:2.7: index, plugin-management, distribution-management, dependency-info, scm, mailing-list, issue-tracking, cim, plugins, license, modules, dependency-management, project-team, summary, dependencies
  [INFO] configuring report plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1
  [INFO] 1 report detected for maven-checkstyle-plugin:3.1.1: checkstyle
  [INFO] Rendering site with default locale English (en)
  [WARNING] No project URL defined - decoration links will not be relativized!
  [INFO] Rendering content with org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
  [INFO] Generating "About" report                --- maven-project-info-reports-plugin:2.7:index
  [INFO] Generating "Plugin Management" report    --- maven-project-info-reports-plugin:2.7:plugin-management
  [INFO] Generating "Distribution Management" report --- maven-project-info-reports-plugin:2.7:distribution-management
  [INFO] Generating "Dependency Information" report --- maven-project-info-reports-plugin:2.7:dependency-info
  [INFO] Generating "Source Repository" report    --- maven-project-info-reports-plugin:2.7:scm
  [INFO] Generating "Mailing Lists" report        --- maven-project-info-reports-plugin:2.7:mailing-list
  [INFO] Generating "Issue Tracking" report       --- maven-project-info-reports-plugin:2.7:issue-tracking
  [INFO] Generating "Continuous Integration" report --- maven-project-info-reports-plugin:2.7:cim
  [INFO] Generating "Project Plugins" report      --- maven-project-info-reports-plugin:2.7:plugins
  [INFO] Generating "Project License" report      --- maven-project-info-reports-plugin:2.7:license
  [INFO] Generating "Project Team" report         --- maven-project-info-reports-plugin:2.7:project-team
  [INFO] Generating "Project Summary" report      --- maven-project-info-reports-plugin:2.7:summary
  [INFO] Generating "Dependencies" report         --- maven-project-info-reports-plugin:2.7:dependencies
  [INFO] Generating "Checkstyle" report           --- maven-checkstyle-plugin:3.1.1:checkstyle
  line 83:15 token recognition error at: '\'
  line 83:21 token recognition error at: '\'
  line 66:38 token recognition error at: '\'
  line 27:22 token recognition error at: '\'
  line 33:0 token recognition error at: '\'
  line 33:2 token recognition error at: '\'
  line 34:0 token recognition error at: '\'
  line 33:0 token recognition error at: '\'
  line 34:0 token recognition error at: '\'
  line 35:0 token recognition error at: '\'
  line 14:16 token recognition error at: '\'
  line 14:22 token recognition error at: '\'
  line 25:0 token recognition error at: '\'
  line 35:16 token recognition error at: '\'
  line 35:22 token recognition error at: '\'
  line 27:13 token recognition error at: ''''
  line 27:12 token recognition error at: '#'
  line 27:15 token recognition error at: '"\!'
  line 27:18 token recognition error at: '";\n'
  line 27:13 token recognition error at: ''\n'
  line 28:0 token recognition error at: '';\n'
  line 27:13 token recognition error at: '\'
  line 27:12 token recognition error at: '\'
  line 27:13 token recognition error at: ''a;'
  line 27:15 token recognition error at: '"abc;\n'
  line 11:42 token recognition error at: '\'
  line 10:12 token recognition error at: '→'
  line 38:35 token recognition error at: '\'
  line 39:39 token recognition error at: '\'
  line 8:8 token recognition error at: '#'
  line 11:11 token recognition error at: '\!'
  line 24:0 token recognition error at: '\'
  line 12:17 token recognition error at: '\'
  line 13:18 token recognition error at: '\'
  line 39:12 token recognition error at: '\'
  line 39:18 token recognition error at: '\'
  line 12:8 token recognition error at: '\'
  line 12:14 token recognition error at: '\'
  line 12:11 token recognition error at: '\'
  line 14:8 token recognition error at: '\'
  line 14:14 token recognition error at: '\'
  line 14:11 token recognition error at: '\'
  line 40:8 token recognition error at: '\'
  line 40:14 token recognition error at: '\'
  line 13:13 token recognition error at: ''''
  line 13:15 token recognition error at: '';\n'
  line 33:14 token recognition error at: '\'
  line 44:8 token recognition error at: '\'
  line 44:14 token recognition error at: '\'
  [INFO] ------------------------------------------------------------------------
  [INFO] BUILD FAILURE
  [INFO] ------------------------------------------------------------------------
  [INFO] Total time:  01:12 h
  [INFO] Finished at: 2024-03-05T20:04:54+05:30
  [INFO] ------------------------------------------------------------------------
  [WARNING]
  [WARNING] Plugin validation issues were detected in 4 plugin(s)
  [WARNING]
  [WARNING]  * org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1
  [WARNING]  * org.apache.maven.plugins:maven-site-plugin:3.12.1
  [WARNING]  * org.apache.maven.plugins:maven-project-info-reports-plugin:2.7
  [WARNING]  * org.apache.maven.plugins:maven-site-plugin:3.3
  [WARNING]
  [WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
  [WARNING]
  [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project sample: Error generating maven-checkstyle-plugin:3.1.1:checkstyle report: Failed during checkstyle execution: There is 1 error reported by Checkstyle 10.14.0-SNAPSHOT with my-checks.xml ruleset. -> [Help 1]
  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project sample: Error generating maven-checkstyle-plugin:3.1.1:checkstyle report
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:347)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
      at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
      at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
      at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
      at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
      at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
      at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910)
      at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
      at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke (Method.java:568)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
  Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating maven-checkstyle-plugin:3.1.1:checkstyle report
      at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:151)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
      at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
      at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
      at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
      at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
      at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
      at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910)
      at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
      at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke (Method.java:568)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
  Caused by: org.apache.maven.reporting.MavenReportException: Failed during checkstyle execution
      at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport (AbstractCheckstyleReport.java:552)
      at org.apache.maven.plugins.checkstyle.CheckstyleReport.executeReport (CheckstyleReport.java:57)
      at org.apache.maven.reporting.AbstractMavenReport.generate (AbstractMavenReport.java:255)
      at org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument (ReportDocumentRenderer.java:226)
      at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render (DefaultSiteRenderer.java:348)
      at org.apache.maven.plugins.site.render.SiteMojo.renderLocale (SiteMojo.java:194)
      at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:143)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
      at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
      at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
      at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
      at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
      at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
      at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910)
      at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
      at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke (Method.java:568)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
  Caused by: org.apache.maven.plugins.checkstyle.exec.CheckstyleExecutorException: There is 1 error reported by Checkstyle 10.14.0-SNAPSHOT with my-checks.xml ruleset.
      at org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle (DefaultCheckstyleExecutor.java:250)
      at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport (AbstractCheckstyleReport.java:533)
      at org.apache.maven.plugins.checkstyle.CheckstyleReport.executeReport (CheckstyleReport.java:57)
      at org.apache.maven.reporting.AbstractMavenReport.generate (AbstractMavenReport.java:255)
      at org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument (ReportDocumentRenderer.java:226)
      at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render (DefaultSiteRenderer.java:348)
      at org.apache.maven.plugins.site.render.SiteMojo.renderLocale (SiteMojo.java:194)
      at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:143)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
      at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
      at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
      at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
      at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
      at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
      at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910)
      at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
      at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke (Method.java:568)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
  [ERROR]
  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
  [ERROR]
  [ERROR] For more information about the errors and possible solutions, please read the following articles:
  [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
  Caught: groovy.lang.GroovyRuntimeException: Error: !
  groovy.lang.GroovyRuntimeException: Error: !
          at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
          at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
          at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
          at diff.executeCmd(diff.groovy:682)
          at diff.executeCmd(diff.groovy:675)
          at diff$executeCmd$15.callCurrent(Unknown Source)
          at diff.runMavenExecution(diff.groovy:647)
          at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
          at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at diff$_generateCheckstyleReport_closure4.doCall(diff.groovy:298)
          at jdk.internal.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
          at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at diff.generateCheckstyleReport(diff.groovy:271)
          at diff$generateCheckstyleReport$11.callCurrent(Unknown Source)
          at diff.launchCheckstyleReport(diff.groovy:232)
          at diff$launchCheckstyleReport$7.callCurrent(Unknown Source)
          at diff.run(diff.groovy:31)
          at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
          at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 9, 2024

@nrmancuso ping! - awaiting your reply

@nrmancuso
Copy link
Member

nrmancuso commented Mar 13, 2024

@nrmancuso - Tried to generate the regression report only for openjdk17 on my local. This time its not OutOfMemoryException, but some other error (not clear to me).

Caused by: org.apache.maven.plugins.checkstyle.exec.CheckstyleExecutorException: There is 1 error reported by Checkstyle 10.14.0-SNAPSHOT with my-checks.xml ruleset.

This means that checkstyle reported an error and failed the build. You can add the -xm "-Dcheckstyle.failsOnError=false" argument that we use in CI to avoid this.

@kalpadiptyaroy
Copy link
Contributor Author

kalpadiptyaroy commented Mar 16, 2024

@nrmancuso - I have generated the total diff-report in my local with this config. -xm "-Dcheckstyle.failsOnError=false".
Have a look - https://kalpadiptyaroy.github.io/

Observation: It consumes approx. 3.6 GB of RAM to generate the entire diff report.

Also, suggest . . . how to move ahead with this PR?

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.
thanks a lot for help on our most complicated Check.

@kalpadiptyaroy
Copy link
Contributor Author

ok to merge. thanks a lot for help on our most complicated Check.

@romani Pleasure! - To work on, and make it work! :)

@kalpadiptyaroy
Copy link
Contributor Author

@nrmancuso - Hi Nick, awaiting your nod to proceed to merge.

@kalpadiptyaroy
Copy link
Contributor Author

@nrmancuso. Ping.

@nrmancuso
Copy link
Member

@nrmancuso. Ping.

There are still two pending reviews with mostly unaddressed items. I expect every item to be replied to and/or addressed in some fashion. I’ve suggested that we open a new issue to deal with modifiers not being correctly identified by this check, and that has not happened either.

@kalpadiptyaroy
Copy link
Contributor Author

@kalpadiptyaroy after some investigation, there seems to be some other issues (as you've alluded to above) that will probably end up blocking the resolution of this issue. Take a look at my example here.

Keep in mind that annotations are also modifiers; if we have some issue with ALL modifiers (which it looks like we do), we will not be able to really fix #13782 until modifiers are handled correctly in general. From the error messages in my example, it looks like violations might be coming from two places (handlers).

Please take a look at our issue tracker, and see if we have any indentation issues for modifiers like in my example. If not, please open one. As far as progress on this and the new issue you may open, please keep in mind the indentation is one of our most problematic and difficult checks. Progress might become slow and time consuming; do not be afraid to close this PR and find something else to contribute.

@nrmancuso - New Issue raised for modifiers #14716

I will re-structure the commits soon. For this PR and the newly created issue soon.

@nrmancuso nrmancuso removed their assignment Mar 30, 2024
@nrmancuso
Copy link
Member

nrmancuso commented Mar 30, 2024

i am removing my assignment from this issue and placing a blocked label until we have a fix for #14716 (which may end up superceding this PR/issue anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants