supplemental: test cases added #12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
Mar 14, 2023
| @@ -0,0 +1,56 @@ | |||
| /* | |||
| com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder | |||
| aliasList = com.puppycrawl.tools.checkstyle.checks.sizes.ParameterNumberCheck=paramnum | |||
There was a problem hiding this comment.
It is not same as <property name="aliasList" value="ParameterNumber=paramnum" />
As you reference in issue.
You should have aliasList=ParameterNumber=paramnum
Or second = to be escaped.
There was a problem hiding this comment.
Or we need both formats in tests
There was a problem hiding this comment.
@romani the issue #11641 is all about supporting the simple name aliasList=ParameterNumber=paramnum.
Right now it only supports the fully qualified name #11542 (comment)
I will most probably send pr for fixing this by today #11641.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supplemental: test cases added
While working on #11641 I noticed that I don't found test cases which use alias list property