Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12331: Test case added for FinalLocalVariableCheck to kill mut… #12611

Merged
merged 1 commit into from Jan 10, 2023
Merged

Issue #12331: Test case added for FinalLocalVariableCheck to kill mut… #12611

merged 1 commit into from Jan 10, 2023

Conversation

Kevin222004
Copy link
Collaborator

Issue #12331: Test case added for FinalLocalVariableCheck to kill mutation

@Kevin222004 Kevin222004 marked this pull request as draft January 9, 2023 12:10
@rnveach rnveach requested a review from romani January 9, 2023 12:32
@Kevin222004 Kevin222004 marked this pull request as ready for review January 9, 2023 12:46
nrmancuso
nrmancuso requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item:

...wl/tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java Outdated Show resolved Hide resolved
@nrmancuso nrmancuso assigned nrmancuso and unassigned romani Jan 9, 2023
romani
romani requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

...wl/tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java Outdated Show resolved Hide resolved
romani
romani approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@nrmancuso nrmancuso merged commit a4d3da8 into checkstyle:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@rnveach rnveach rnveach approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Assignees

@nrmancuso nrmancuso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kevin222004 @romani @rnveach @nrmancuso