Issue #11807: fixes exception on records and fields in RequireThis #12471
Conversation
| result = true; | ||
| break; | ||
| final DetailAST parent = member.getParent(); | ||
| if (parent.getType() != TokenTypes.RECORD_COMPONENT_DEF) { |
There was a problem hiding this comment.
I wasn't fully sure, but I assume this RECORD_COMPONENT_DEF is not a final field by default?
There was a problem hiding this comment.
record components are implicitly final.
There was a problem hiding this comment.
Edit: It seems this code isn't correct. I will try to fix.
There was a problem hiding this comment.
The code should be "fixed" now.
|
Regression: http://rveach.no-ip.org:81/checkstyle/regression/317/ |
...crawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisRecordsWithCheckFields.java
Outdated
Show resolved
Hide resolved
...crawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisRecordsWithCheckFields.java
Outdated
Show resolved
Hide resolved
|
It would be a good idea to run check regression over the projects file that found the NPE: https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/latest-projects-to-test-on.properties. The older project file has projects that have little or no record usage. |
rnveach
force-pushed
the
issue_11807
branch
2 times, most recently
from
f5105f5
to
1196640
Compare
...crawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisRecordsWithCheckFields.java
Show resolved
Hide resolved
|
Regression: http://rveach.no-ip.org:81/checkstyle/regression/318/ Only 1 difference, no new violation. |
...ools/checkstyle/checks/coding/requirethis/InputRequireThisRecordsWithCheckFieldsOverlap.java
Outdated
Show resolved
Hide resolved
Issue #11807