New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #12345: fix NoWhitespaceAfterCheck false positive #12372
Conversation
Github, generate report |
e708e25
to
bb71eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this case to Inputs
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e708e25_2022143653/reports/diff/openjdk17/index.html#A43
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e708e25_2022143653/reports/diff/openjdk17/index.html#A21
Please address Checker failures.
bb71eb8
to
b29ac75
Compare
done |
CI failures seem unrelated and jist some infra issues |
Rebase for new travis fixes. |
Github, rebase |
b29ac75
to
c9a45ad
Compare
it looks like rebase action is broken
Created #12404 for it |
error-prone check failed for some infra issue |
I set it to re-run but it has been queued for a bit now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge , but we need to rebase to make sure CI is green, we changed it a lot recently
c9a45ad
to
595efe3
Compare
rebased |
CI is missing like 43 runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items:
.../tools/checkstyle/checks/whitespace/nowhitespaceafter/InputNoWhitespaceAfterTestDefault.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheck.java
Show resolved
Hide resolved
595efe3
to
9acde5f
Compare
From https://app.circleci.com/pipelines/github/checkstyle/checkstyle?branch=pull%2F12372: CircleCI is not running on this branch due to sanctions. @strkkk @rnveach @romani @pbludov FYI:
|
Hm, interesting that CI started running in this PR after pushing up #12455. Edit: not really, I forgot that status is on the commit, not PR |
@nrmancuso please either merge or assign next reviewer :) |
Closes #12345
Diff Regression config: https://gist.githubusercontent.com/strkkk/26466254f89c32d8f1a6bd53b6f5b251/raw/e31682f867c2d357b605523c1a80cee50fab9c18/config_single.xml