Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12345: fix NoWhitespaceAfterCheck false positive #12372

Merged
merged 1 commit into from Nov 25, 2022

Conversation

strkkk
Copy link
Member

@strkkk strkkk commented Nov 5, 2022

@strkkk
Copy link
Member Author

strkkk commented Nov 5, 2022

Github, generate report

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strkkk
Copy link
Member Author

strkkk commented Nov 13, 2022

CI failures seem unrelated and jist some infra issues

@rnveach
Copy link
Member

rnveach commented Nov 13, 2022

@strkkk

CI failures seem unrelated

Rebase for new travis fixes.

@strkkk
Copy link
Member Author

strkkk commented Nov 13, 2022

Github, rebase

@strkkk
Copy link
Member Author

strkkk commented Nov 13, 2022

it looks like rebase action is broken

Collecting information about PR #12372 of checkstyle/checkstyle...
Base branch for PR #12372 is master
fatal: detected dubious ownership in repository at '/github/workspace'
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

Created #12404 for it

@strkkk
Copy link
Member Author

strkkk commented Nov 14, 2022

error-prone check failed for some infra issue

@rnveach
Copy link
Member

rnveach commented Nov 14, 2022

I set it to re-run but it has been queued for a bit now.

@strkkk strkkk requested a review from romani November 14, 2022 21:19
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge , but we need to rebase to make sure CI is green, we changed it a lot recently

@strkkk
Copy link
Member Author

strkkk commented Nov 24, 2022

rebased

@romani romani assigned nrmancuso and unassigned romani Nov 24, 2022
@rnveach
Copy link
Member

rnveach commented Nov 25, 2022

CI is missing like 43 runs.

Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items:

@nrmancuso
Copy link
Member

From https://app.circleci.com/pipelines/github/checkstyle/checkstyle?branch=pull%2F12372:

CircleCI is not running on this branch due to sanctions.

@strkkk @rnveach @romani @pbludov FYI:

If you come across the above error, preventing your builds from running on CircleCI, your account may have recently been restricted as part of our compliance with U.S. export control laws and sanctions.

Our recent actions to restrict certain user accounts were taken to comply with U.S. trade control laws imposed by the U.S. Treasury Department’s Office of Foreign Assets Controls (OFAC) and U.S. Commerce Department’s Bureau of Industry and Security (BIS), which restrict what CircleCI services can be made available to users in certain countries and territories. These include:

the Crimea, Donetsk Oblast, and Luhansk regions of Ukraine,
Belarus
Cuba
Iran
North Korea
Russia
Syria

From https://support.circleci.com/hc/en-us/articles/360043679453-CircleCI-Terms-of-Service-Violation-Sanctioned-Country

@nrmancuso
Copy link
Member

nrmancuso commented Nov 25, 2022

Hm, interesting that CI started running in this PR after pushing up #12455.

Edit: not really, I forgot that status is on the commit, not PR

@strkkk
Copy link
Member Author

strkkk commented Nov 25, 2022

@nrmancuso please either merge or assign next reviewer :)

@romani romani merged commit 8bf2481 into checkstyle:master Nov 25, 2022
@strkkk strkkk deleted the 12345_NoWhitespaceAfter branch November 25, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in NoWhiteSpaceAfter
4 participants