Issue #11747: Migrate codenarc to travis CI #12349
Conversation
Vyom-Yadav
force-pushed
the
migrateCodenarcToTravis
branch
7 times, most recently
from
a73c088
to
4775147
Compare
.ci/codenarc.sh
Outdated
| @@ -1,6 +1,5 @@ | |||
| #!/bin/bash | |||
| # Attention, there is no "-x" to avoid problems on Travis | |||
| set -e | |||
There was a problem hiding this comment.
No need to exit if groovy ./.ci/codenarc.groovy fails, we still need to echo the reason for failure, for example, if groovy is not installed or JAVA_HOME is not set.
There was a problem hiding this comment.
This is required to fail fast and do not continue execution I'd something existing with error code.
Please share more details and log on this update
There was a problem hiding this comment.
Actually set -e can stay, error in groovy installation or JAVA_HOME would be shown in before_script
There was a problem hiding this comment.
Yes, placing -e in Travis level code is damaging it's execution, but in script it is ok
.ci/codenarc.sh
Outdated
| @@ -1,6 +1,5 @@ | |||
| #!/bin/bash | |||
| # Attention, there is no "-x" to avoid problems on Travis | |||
| set -e | |||
There was a problem hiding this comment.
This is required to fail fast and do not continue execution I'd something existing with error code.
Please share more details and log on this update
Vyom-Yadav
force-pushed
the
migrateCodenarcToTravis
branch
4 times, most recently
from
e0955b4
to
4fc8b70
Compare
Vyom-Yadav
force-pushed
the
migrateCodenarcToTravis
branch
from
4fc8b70
to
e9fb950
Compare
| before_script: | ||
| - | | ||
| if [[ $TRAVIS_CPU_ARCH == 'ppc64le' ]]; then | ||
| export JAVA_HOME=/usr/lib/jvm/adoptopenjdk-11-hotspot-ppc64el |
There was a problem hiding this comment.
@romani Isn't this better suited to actually be in ./.ci/travis.sh install-adoptium-jdk as it is connected to the JRE and to keep it all together as needed for travis.
There was a problem hiding this comment.
I ok to keep installation details in travis.yml.
I try to keep Travis specific validations in travis.sh (but potentially with extra effort, they can be moved to other CI)
There was a problem hiding this comment.
Let's keep evidence of weird architecture in yml file, to remind us of this when adding new jobs here.
Resolves #11747
Proof of working:
Failing due to extra import - https://app.travis-ci.com/github/checkstyle/checkstyle/jobs/586922249