Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Resolve Pitest suppression for SingleSpaceSeparatorCheck #12289

Closed
wants to merge 3 commits into from

Conversation

Kevin222004
Copy link
Contributor

@Kevin222004 Kevin222004 commented Oct 10, 2022

minor: Resolve Pitest suppression for SingleSpaceSeparatorCheck

Related to #12283

Diff Regression config: https://gist.githubusercontent.com/Kevin222004/55bba7110290f08feb12e3c4f36976e4/raw/a3bd29dd8d9035b48d5bbfba68042e33e4b82526/CONFIG.xml

@Kevin222004
Copy link
Contributor Author

Just for testing not to merge

@Kevin222004
Copy link
Contributor Author

Github, generate report

@github-actions
Copy link
Contributor

Report generation job failed on phase "make_report", step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/3218970790

@Kevin222004
Copy link
Contributor Author

Github, generate report

@github-actions
Copy link
Contributor

Report generation job failed on phase "parse_body", step "React with rocket on run".
Link: https://github.com/checkstyle/checkstyle/actions/runs/3219041711

@Kevin222004
Copy link
Contributor Author

Github, generate report

@romani
Copy link
Member

romani commented Oct 10, 2022

Please investigate code:

while (currentNode.getNextSibling() == null && currentNode.getParent() != parent) {
                    currentNode = currentNode.getParent();
                }
                currentNode = currentNode.getNextSibling();

It might a reason why parent node is not required, as we exist "while " by null sibling, that is reasonable

@nrmancuso
Copy link
Member

@Kevin222004 ping

@Kevin222004
Copy link
Contributor Author

Kevin222004 commented Nov 29, 2022

@Kevin222004 ping

this is not required as i can generate in my local know now so i am closing it.
due to exam right know not able to work on the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants