Issue #12260: Resolve Pitest suppression for AbstractParenPadCheck - 2

[Kevin222004]

Issue #12260: Resolve Pitest suppression for AbstractParenPadCheck - 2

killing mutation

checkstyle/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml

Line 8 in 70bbcd8

<description>replaced call to java/lang/String::toUpperCase with receiver</description>

[Kevin222004]

1. pitest report
   https://kevin222004.github.io/AfterChanges/com.puppycrawl.tools.checkstyle.checks.whitespace/AbstractParenPadCheck.java.html
   Surviving Mutation: java/lang/String::toUpperCase with receiver → SURVIVED at line 80

2. Mutated code
   our Surviving mutation is java/lang/String::toUpperCase with receiver → SURVIVED
   this toUpperCase function will change the string as --> SPACE
   while setting the property space to option
   if we see without mutation the code looks like.
   option = PadOption.valueOf(optionStr.trim());

but we can't remove or make any changes to this Method because enum has been set to be like
SPACE so all the letter we set to option is must be in Uppercase

3. Analysis

a) the toUpperCase function will work here as like

<property name="option" value="space"/>

as the output of this code we will get only SPACE which is good

b) if we remove the toUpperCase function and then try to set the property

<property name="option" value="space"/>

it will give us the error like

com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize module TreeWalker
 - cannot initialize module ParenPad - Cannot set property 'option' to 'space'
        at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:481)
error continue...

4. How to kill this

a) currently in our testing case all the test case which are available
that all have set the property directly SPACE so the usage of toUpperCase function
is nothing in all the condition thats why it is Mutated

now to kill this mutation i have create the test file with
space so it will appear to code as SPACE
as know the usage of toUpperCase come so the muattion will be killed
https://kevin222004.github.io/Uppercase/com.puppycrawl.tools.checkstyle.checks.whitespace/index.html

[rnveach]

1 minor change

[rnveach]

I noticed this in this PR and previous. expected is indented 1 less then where it should.

Please ensure they line up. Please fix previous test in this same PR.

[Kevin222004]

done

[romani]

Items

[romani]

Ok to merge