Issue #12210: Add method to ignore unstable checker framework violations #12215
Conversation
|
Codenarc failing |
Vyom-Yadav
force-pushed
the
fixCheckerFrameworkUnstableErrorMethod
branch
2 times, most recently
from
4fb8b76
to
da8c139
Compare
Done. |
Vyom-Yadav
force-pushed
the
fixCheckerFrameworkUnstableErrorMethod
branch
from
da8c139
to
172aeb9
Compare
Vyom-Yadav
force-pushed
the
fixCheckerFrameworkUnstableErrorMethod
branch
from
172aeb9
to
b4f8be9
Compare
|
Codenarc again |
Vyom-Yadav
force-pushed
the
fixCheckerFrameworkUnstableErrorMethod
branch
from
b4f8be9
to
b2bd6b6
Compare
Done. |
| return i | ||
| if (this.isUnstable() || other.isUnstable()) { | ||
| final String messageWithoutLineNumber = getMessage().replaceAll('\\d+', '') | ||
| final String thatMessageWithoutLineNumber = other.getMessage().replaceAll('\\d+', '') |
There was a problem hiding this comment.
Why didn't we do this in the constructor? This is suppose to be an immutable class.
Would also save on execution time, as this gets run probably every time a new entry gets added to the set for nearly everything in the set multiple times.
We obviously don't care about the numbers anyways.
There was a problem hiding this comment.
This is suppose to be an immutable class
It still is, the original field is not modified.
Would also save on execution time, as this gets run probably every time a new entry gets added to the set for nearly everything in the set multiple times.
It will only run for unstable mutations, only a few of them are there.
We obviously don't care about the numbers anyways.
I feel it would be better if we don't modify the original error itself.
| return i | ||
| if (this.isUnstable() || other.isUnstable()) { | ||
| final String messageWithoutLineNumber = getMessage().replaceAll('\\d+', '') | ||
| final String thatMessageWithoutLineNumber = other.getMessage().replaceAll('\\d+', '') |
There was a problem hiding this comment.
Will numbers that were an issue always be 3 digits? Maybe consider changing the regexp to just match 3 digit numbers.
Also why not match the # too?
There was a problem hiding this comment.
Will numbers that were an issue always be 3 digits?
No, they are not, see the updated issue description, we have entries like temp-var-20910
Also why not match the # too?
Not possible as we have entries like temp-var-20910, also if we could do it, there is no point in doing it, would increase the complexity of regex unnecessarily.
|
I think we breach the equals and hashcode contract here, I am investigating it. |
|
If you think this is broken, I recommend adding a print out of full actual so it can be viewed in the logs and debugged easier. |
Resolves #12210