Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Remove an ArchUnit Frozen Violation #12205

Closed
wants to merge 2 commits into from

Conversation

Vyom-Yadav
Copy link
Member

The second commit is under review. For demonstration purposes, DO NOT MERGE.

@romani
Copy link
Member

romani commented Sep 16, 2022

@nrmancuso
Copy link
Member

nrmancuso commented Sep 16, 2022

You cannot see it, test passes and suppression is automatically removed/ added to freeze file

@Vyom-Yadav
Copy link
Member Author

One more thing, if the user pushes PR which will change the ArchUnit store, but he did not execute the test on his local machine, then it will be caught in the CI as we do:

checkstyle/.ci/validation.sh

Lines 1041 to 1049 in ba66ce2

git-diff)
if [ "$(git status | grep 'Changes not staged\|Untracked files')" ]; then
printf "Please clean up or update .gitattributes file.\nGit status output:\n"
printf "Top 300 lines of diff:\n"
git status
git diff | head -n 300
false
fi
;;

It will be similar to when we update something in the module and don't run the Metadata related tests which update the check metadata and later it can be seen in the CI.

@nrmancuso
Copy link
Member

Closing this PR, it has served it's purpose and we have merged #12190

@nrmancuso nrmancuso closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants