Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3955: corrected tokens so all are required #12108

Merged
merged 1 commit into from Sep 22, 2022
Merged

Issue #3955: corrected tokens so all are required #12108

merged 1 commit into from Sep 22, 2022

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Aug 27, 2022 •
edited by romani

Issue #3955

it is breaking compatibility .... will need review from all.

@romani
Copy link
Member

romani commented Aug 27, 2022

it is breaking compatibility .... will nee review from all.

@pbludov pbludov assigned nrmancuso and unassigned pbludov Aug 28, 2022
@nrmancuso nrmancuso mentioned this pull request Aug 29, 2022
Closed
@nrmancuso
Copy link
Member

Github, generate site

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited by nrmancuso

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b387c12_2022020408/index.html

Link to docs: https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b387c12_2022020408/config_coding.html#IllegalInstantiation

nrmancuso
nrmancuso approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement to this check; documentation and usage is clear now.

@nrmancuso nrmancuso assigned strkkk and unassigned nrmancuso Aug 30, 2022
@rnveach rnveach assigned romani and unassigned strkkk Sep 2, 2022
@rnveach
Copy link
Member Author

rnveach commented Sep 20, 2022

@romani ping

@rnveach rnveach force-pushed the issue_3955 branch 2 times, most recently from 10ce211 to d6d443b Compare September 20, 2022 22:31
@romani
Copy link
Member

romani commented Sep 22, 2022

Github, generate web site

@github-actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/d6d443b_2022125938/index.html

romani
romani requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have test that shows that user can define FQN of inner class to be validated ?

items:

src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheck.java Show resolved Hide resolved
@rnveach
Copy link
Member Author

rnveach commented Sep 22, 2022

Do we have test that shows that user can define FQN of inner class to be validated ?

InputIllegalInstantiationSemantic2 has:

classes = java.lang.Boolean,com.puppycrawl.tools.checkstyle.checks.coding.illegalinstantiation.\
          InputModifier,java.io.File,java.awt.Color

Please note InputModifier.

@romani
Copy link
Member

romani commented Sep 22, 2022

Github, generate web site

@github-actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4d91bef_2022150859/index.html

romani
romani approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 37842d2 into checkstyle:master Sep 22, 2022
@rnveach rnveach deleted the issue_3955 branch September 22, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@pbludov pbludov pbludov approved these changes

@strkkk strkkk strkkk approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rnveach @romani @nrmancuso @pbludov @strkkk