Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: put example of enableExternalDtdLoad to xdoc #11857

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

romani
Copy link
Member

@romani romani commented Jul 7, 2022

taken from #10356 (comment)

error message modified a bit to match limit of 100 symbols, "Name" word is removed, I think it will be not noticable.

Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10356 (comment)
I feel this documentation does not completely detail why this is hidden behind a property and what are the security issues with enabling it without any thought.

src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
@romani
Copy link
Member Author

romani commented Jul 10, 2022

Github, generate website

@github-actions
Copy link
Contributor

src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
@romani romani force-pushed the doc-dtd-external branch 2 times, most recently from 14f717f to a7b6107 Compare July 10, 2022 15:29
@rnveach
Copy link
Member

rnveach commented Jul 10, 2022

[ERROR] Failures: 
[ERROR]   XdocsPagesTest.testAllSubSections:347 config_system_properties.xml sub-section Examples for section Enable External DTD load must match
expected: Enable_External_DTD_load_Examples
but was : External_DTD_Examples
[INFO] 
[ERROR] Tests run: 3824, Failures: 1, Errors: 0, Skipped: 2

@romani
Copy link
Member Author

romani commented Jul 10, 2022

build problem is fixed.

@romani
Copy link
Member Author

romani commented Jul 10, 2022

Github, generate website

@github-actions
Copy link
Contributor

@romani
Copy link
Member Author

romani commented Jul 10, 2022

Github, generate web site

@romani
Copy link
Member Author

romani commented Jul 10, 2022

$ cat checkstyle-test.xml

I now feel that is better to remove this and similar cats line from doc. do you agree ?

@github-actions
Copy link
Contributor

Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok to remove cat lines if it is made explicitly clear what each file is.

@romani
Copy link
Member Author

romani commented Jul 10, 2022

Github, generate web site

@nrmancuso nrmancuso assigned strkkk and unassigned nrmancuso Jul 11, 2022
src/xdocs/config_system_properties.xml Outdated Show resolved Hide resolved
@strkkk strkkk merged commit a3b795d into checkstyle:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants