Issue #11736: Support qualified annotation names for MissingJavadocTypeCheck #11827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoyanK7
force-pushed
the
issue/11736-support-qualified-annotation-names
branch
from
7ede563
to
66c557a
Compare
nrmancuso
requested changes
Jul 3, 2022
There was a problem hiding this comment.
Please generate check regression report for all checks that use this method (See https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#report-generation):
➜ checkstyle git:(master) grep -lR "AnnotationUtil.containsAnnotation(" | grep -iv "Test" | uniq
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/MissingJavadocTypeCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/MissingJavadocMethodCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationCheck.java
Few items to start with:
src/main/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtil.java
Outdated
Show resolved
Hide resolved
...ckstyle/checks/javadoc/missingjavadocmethod/InputMissingJavadocMethodAllowedAnnotations.java
Outdated
Show resolved
Hide resolved
|
Please look at failed CI they will guide you on what to improve. |
stoyanK7
force-pushed
the
issue/11736-support-qualified-annotation-names
branch
from
66c557a
to
cbb051d
Compare
|
No need to re-request review, please reply “done” to each item as you complete it and confirm that changes are pushed. Please generate check regression reports before we proceed. |
|
Github, generate report |
romani
requested changes
Jul 4, 2022
src/main/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtil.java
Outdated
Show resolved
Hide resolved
romani
requested changes
Jul 4, 2022
src/test/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtilTest.java
Outdated
Show resolved
Hide resolved
stoyanK7
force-pushed
the
issue/11736-support-qualified-annotation-names
branch
2 times, most recently
from
c8e666b
to
8aa65e4
Compare
stoyanK7
force-pushed
the
issue/11736-support-qualified-annotation-names
branch
from
8aa65e4
to
71d7c0c
Compare
romani
requested changes
Jul 4, 2022
...ckstyle/checks/javadoc/missingjavadocmethod/InputMissingJavadocMethodAllowedAnnotations.java
Outdated
Show resolved
Hide resolved
stoyanK7
force-pushed
the
issue/11736-support-qualified-annotation-names
branch
from
71d7c0c
to
d152226
Compare
nrmancuso
requested changes
Jul 6, 2022
There was a problem hiding this comment.
Please add test cases:
- With multiple, qualified
skipAnnotations, i.e. MissingJavadocType: Support qualified annotation names #11736 (comment) - With multiple (3+) annotations on a given type, with a few variations of number of skipAnnotations.
strkkk
reviewed
Jul 6, 2022
...tyle/checks/javadoc/missingjavadoctype/InputMissingJavadocTypeFullyQualifiedAnnotation4.java
Outdated
Show resolved
Hide resolved
stoyanK7
force-pushed
the
issue/11736-support-qualified-annotation-names
branch
from
d152226
to
e5cad07
Compare
Done!
|
nrmancuso
approved these changes
Jul 8, 2022
strkkk
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11736
Adds support for qualified annotation names in
MissingJavadocTypeCheck.Diff Regression config: https://gist.githubusercontent.com/stoyanK7/37de7a689373daea1df3ec5f4e16efbb/raw/4f28948a768d7cf7fb3a59f6f1faf9e6152d28fa/config.xml