Issue #11720: Kill surviving mutation in RequireThisCheck #11775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11720
Hardcoded mutation tested at #11771
Reports with hardcoded mutation (clean):
This mutation falls in the category:
Rationale:
Without the condition
if (toVisit == null)
,curNode = curNode.getParent();
will be executed even whentoVisit != null
, iftoVisit != null
, we will break from the loopwhile (curNode != null && toVisit == null)
and on the very next line after while loop,curNode
gets updatedcurNode = toVisit;
, so the previous assignment ofcurNode = curNode.getParent();
does not make a difference.