Issue #11726: Automate creation of settings.xml file for release #11743
Conversation
.ci/prepare-settings.sh
Outdated
|
|
||
| if cmp -s "$file1" "$file2"; then | ||
| date=$(date +"%m%d%y") | ||
| mv ~/.m2/settings.xml ~/.m2/settings.xml.backup."${date}" |
.ci/prepare-settings.sh
Outdated
| mv ~/.m2/settings.xml ~/.m2/settings.xml.backup."${date}" | ||
| fi | ||
|
|
||
| cp .ci-temp/release-settings.xml ~/.m2/settings.xml |
There was a problem hiding this comment.
you have variables for these files
There was a problem hiding this comment.
We have variables for these files but we can use this only if we run those in Travis CI.
eg: MVN_SETTINGS=${TRAVIS_HOME}/.m2/settings.xml
There was a problem hiding this comment.
we should not use CI specific variables, this script should be executable on any CI and any local.
There was a problem hiding this comment.
I think exact path might work better then variable - it is almost unlikely to change
There was a problem hiding this comment.
what I mean is that several lines above it is
TEMP_SETTING="./.ci-temp/release-settings.xml"
SETTING="~/.m2/settings.xml"
so this command can be just cp $TEMP_SETTING $SETTING and duplcation is avoided
There was a problem hiding this comment.
now I see it, thanks a lot.
done.
| replace SONATYPE_USER | ||
| replace SONATYPE_PWD | ||
| replace GPG_PASSPHRASE | ||
| replace GPG_KEY |
There was a problem hiding this comment.
Shouldn't these names be more Checkstyle specific? IE: CS_GPG_KEY or CHECKSTYLE_GPG_KEY
There was a problem hiding this comment.
I am not sure for now to put CS as prefix for all.
There was a problem hiding this comment.
Aren't these just environment variables the user has set on their machine going by checkForVariable? Are these environment variables needed some place else besides for this script?
There was a problem hiding this comment.
Just a variables, not used in other scripts.
We never named variables with CS prefix, I not sure that we should start now.
Resolves: Issue #11726
release-settings.xmlfile.prepare-setting.shand it copyrelease-setting.xmlto.ci-temp.ci-temp~/.m2/settigns.xml.backup.{date}~/.m2/settigns.xml