Issue #11637: Used Shellcheck to resolve SC2236 in Shell Script #11664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrmancuso
requested changes
May 22, 2022
There was a problem hiding this comment.
@Rahulkhinchi03 please add separate minor commit to fix same violation in .github/workflows/no_old_refs.yml:
➜ checkstyle git:(master) ✗ grep -R "! -z"
.ci/no_old_refs.sh:if [ ! -z "$PR_HEAD_REPO_NAME" ]; then
.ci/no_old_refs.sh: if [ ! -z "$LINKED_ISSUES" ]; then
.ci/checkchmod.sh:if [[ ! -z $CHMOD ]]; then
.ci/checkchmod.sh:if [[ ! -z $CHMOD ]]; then
.github/workflows/no_old_refs.yml: if [ ! -z "$LINKED_ISSUES" ]; then
nrmancuso
requested changes
May 22, 2022
There was a problem hiding this comment.
@Rahulkhinchi03 please make commit descriptive for anyone to be able understand, such as minor: Use -n instead of ! -z
nrmancuso
approved these changes
May 23, 2022
romani
approved these changes
May 23, 2022
strkkk
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
SC2236#11637SC2236: Use -n instead of ! -z(https://github.com/koalaman/shellcheck/wiki/SC2236)