Some reworking for test structures #11603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnveach
commented
May 4, 2022
|
|
||
| if (moduleCreationOption == ModuleCreationOption.IN_TREEWALKER) { | ||
| protected void addConfigToChecker(Checker checker, Class<?> moduleClass, | ||
| Configuration moduleConfig) throws Exception { |
There was a problem hiding this comment.
This is the method that can be overridden to allow new walkers and why the old enum way had to be removed.
pbludov
reviewed
May 6, 2022
src/it/java/org/checkstyle/base/AbstractItModuleTestSupport.java
Outdated
Show resolved
Hide resolved
nrmancuso
requested changes
May 6, 2022
src/it/java/org/checkstyle/base/AbstractItModuleTestSupport.java
Outdated
Show resolved
Hide resolved
src/it/java/org/checkstyle/base/AbstractItModuleTestSupport.java
Outdated
Show resolved
Hide resolved
src/test/java/com/puppycrawl/tools/checkstyle/AbstractModuleTestSupport.java
Show resolved
Hide resolved
rnveach
force-pushed
the
a_fixes
branch
2 times, most recently
from
88be7df
to
31a41c0
Compare
nrmancuso
approved these changes
May 7, 2022
pbludov
approved these changes
May 7, 2022
romani
requested changes
May 7, 2022
src/test/java/com/puppycrawl/tools/checkstyle/AbstractModuleTestSupport.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11604
First commit is a simple synchronize between Test and IT where similar code is.
Second commit is the bigger change. I reworked how we build the Checker tree so it is more streamlined and not passing around the enumeration.
createCheckerwill now handle the current given module and identify if it needs a TreeWalker or other similar intermediary between it and the module. It also removed random config names and more closely used the ones they represent.I could not make similar changes to the IT side as the IT side has some weird complexities that need to be dealt with. We pass the name of the check and not the full class. We have to pull things from an existing config, and we only do partial pulls, still rebuild the missing pieces. There are also some tests that pull in more information from the config to not duplicate it making it all very complicated and needing its own rewrite.
I at least removed and centralized the code for
getModuleConfigandgetModuleConfigsfor IT.