Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #10924: Update SeparatorWrapCheck to use code points #11456

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

MUzairS15
Copy link
Contributor

@MUzairS15 MUzairS15 commented Mar 23, 2022

Issue #10924: Updated SeparatorWrapCheck to use code points

src % cat config.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
        "https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="Checker">
    <module name="TreeWalker">
        <module name="SeparatorWrap">
            <property name="option" value="NL"/>
        </module>
    </module>
</module>

src % cat src/main/java/Test.java 
public class Test {
        void test() {
                String s = "sda";
                /* 馃巹馃巹 */ s.
                        isEmpty(); // violation but not reported
                /* sda */ s.
                        isEmpty(); // violation and reported
        }

}      
                                                                                                                                                                  
src % java -jar checkstyle-10.0-all.jar -c config.xml src/main/java/Test.java
Starting audit...
[ERROR] Test.java:6:28: '.' should be on a new line. [SeparatorWrap]
Audit done.
Checkstyle ends with 1 errors.

Diff Regression config: https://gist.githubusercontent.com/MUzairS15/7241576ae68289631f7560ece75b4f2a/raw/ea1dac19a8541caa225ec90c881b81fc11f4411e/config.xml

@MUzairS15
Copy link
Contributor Author

MUzairS15 commented Mar 23, 2022

Github, generate report

@nrmancuso nrmancuso self-requested a review March 23, 2022 12:31
@nrmancuso nrmancuso self-assigned this Mar 23, 2022
@nrmancuso
Copy link
Member

nrmancuso commented Mar 23, 2022

@MUzairS15 please update PR description, CI is failing. Also, make sure that mvn clean verify passes on your local.

Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor item:

@nrmancuso nrmancuso requested a review from romani March 26, 2022 17:13
@nrmancuso nrmancuso assigned romani and unassigned nrmancuso Mar 26, 2022
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit b862853 into checkstyle:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants