-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #10924: Update TrailingCommentCheck to use code points #11422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nick-mancuso Pls review. |
I would expect a violation on line 9 as well. |
Updating PR |
MUzairS15
force-pushed
the
trailingcomment
branch
from
March 17, 2022 11:31
93891dd
to
b8e1615
Compare
MUzairS15
changed the title
minor: Removed usage of getLines in TrailingCommentCheck
Issue #10924: Update TrailingCommentCheck to use code points
Mar 17, 2022
Github, generate report |
nrmancuso
requested changes
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor:
src/main/java/com/puppycrawl/tools/checkstyle/checks/TrailingCommentCheck.java
Outdated
Show resolved
Hide resolved
MUzairS15
force-pushed
the
trailingcomment
branch
from
March 18, 2022 06:31
b8e1615
to
190ca72
Compare
MUzairS15
force-pushed
the
trailingcomment
branch
from
March 18, 2022 06:42
190ca72
to
ab39e3e
Compare
nrmancuso
requested changes
Mar 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item:
src/main/java/com/puppycrawl/tools/checkstyle/checks/TrailingCommentCheck.java
Show resolved
Hide resolved
nrmancuso
approved these changes
Mar 19, 2022
romani
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10924: Updated TrailingCommentCheck to use code points
Diff Regression config: https://gist.githubusercontent.com/MUzairS15/338aa5815422d64fc1e119861cac1336/raw/ef19e01810ccc472e359e17175cb8dd5885d983c/config.xml
Proof that check requires update: #11422 (comment)