Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4845: removed usage of TokenTypes from inputs #11402

Merged
merged 1 commit into from Mar 12, 2022

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Mar 12, 2022

Issue #4845

Targetted TokenTypes and switch them to Calendar which also has public static integer fields.

@@ -12,9 +12,9 @@

import com.puppycrawl.tools.checkstyle.FileStatefulCheck;
import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this is the meta scapper, I wasn't seeing any uses of these imports so I removed them because of their connection to this issue.
Let me know if there is a reason for these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck git history.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romani When I rechecked one file InputJavadocMetadataScraperNoCodeInFileCheck, the file had been like that since the beginning.

Pull #10827: reworks JavadocMetadataScrapperTest to make more sense

This is more me moving files around.

Issue #8771: Improve code coverage for metadata generator classes

This is where the file really started and it is the same. I didn't see anything in PRs, and this issue was for code coverage. I can only assume we wanted more of a representation of the Check without copying the check's full source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's merge this PR

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI pass

@rnveach rnveach merged commit 506496c into checkstyle:master Mar 12, 2022
@rnveach rnveach deleted the issue_4845_1 branch March 12, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants