Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: bump maven-compiler-plugin from 3.9.0 to 3.10.0 #11313

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2022

Bumps maven-compiler-plugin from 3.9.0 to 3.10.0.

Release notes

Sourced from maven-compiler-plugin's releases.

3.10.0

馃毃 Removed

馃殌 New features and improvements

馃悰 Bug Fixes

馃摝 Dependency updates

馃摑 Documentation updates

馃敡 Build

Commits
  • f4239a4 [maven-release-plugin] prepare release maven-compiler-plugin-3.10.0
  • fda9729 fix typo gtrhhhrhr
  • 49a40ab use github
  • bd72d75 back to snapshot again
  • 2863d29 [maven-release-plugin] prepare release maven-compiler-plugin-3.10.0
  • 807d4e5 use last release plugin version
  • 037670c restore snapshot version
  • 07d635a [maven-release-plugin] prepare for next development iteration
  • a0fa151 [maven-release-plugin] prepare release maven-compiler-plugin-3.10.0
  • 500ade4 add more jdk for testing (#93)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 14, 2022
@rnveach
Copy link
Member

rnveach commented Feb 14, 2022

2 of the CIs seem to have some weird errors related to package-info files:

[ERROR] testAllPropertyTypesAreUsed  Time elapsed: 3.408 s  <<< ERROR!
java.lang.NoClassDefFoundError: com\puppycrawl\tools\checkstyle\ant\package-info (wrong name: com/puppycrawl/tools/checkstyle/ant/package-info)
	at com.puppycrawl.tools.checkstyle.XdocsPropertyTypeTest.testAllPropertyTypesAreUsed(XdocsPropertyTypeTest.java:43)

@pbludov pbludov self-assigned this Feb 15, 2022
@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

I'm on it

@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

Cirrus and Appveyor are both CI hosted on Windows.

@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.9.0...maven-compiler-plugin-3.10.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-compiler-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@pbludov pbludov force-pushed the dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.10.0 branch from dd5c25c to 8159a24 Compare February 15, 2022 09:41
@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

The exception is thrown here: https://github.com/openjdk/jdk17/blob/74007890bb9a3fa3a65683a3f480e399f2b1a0b6/src/hotspot/share/classfile/classFileParser.cpp#L5797

It looks like the problem is not platform dependent, but JDK dependent.

@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

Solved by turning the new feature off.

<configuration>
<source>${java.version}</source>
<target>${java.version}</target>
<createMissingPackageInfoClass>false</createMissingPackageInfoClass>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version brings a new feature which is not stable in some environments.
For some reason, the feature is enabled by default. We don't need this feature.

@pbludov pbludov assigned romani and unassigned pbludov Feb 15, 2022
@pbludov pbludov requested a review from romani February 15, 2022 10:47
@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

Related issue in the tracker: https://issues.apache.org/jira/browse/MCOMPILER-205

@dbwiddis
Copy link

See https://issues.apache.org/jira/browse/MCOMPILER-485

@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

See https://issues.apache.org/jira/browse/MCOMPILER-485

Thank you Daniel. The correct solution is to wait for the fix.

@pbludov
Copy link
Member

pbludov commented Feb 15, 2022

@dependabot ignore this minor version

@dependabot dependabot bot closed this Feb 15, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 15, 2022

OK, I won't notify you about version 3.10.x again, unless you re-open this PR or update to a 3.10.x release yourself.

@dependabot dependabot bot deleted the dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.10.0 branch February 15, 2022 15:28
@dbwiddis
Copy link

FYI, "ignore this patch version" is not documented but works and it's what I did. Just in case 3.10.1 is next...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants