Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9463: update example of AST for TokenTypes.LITERAL_BOOLEAN #10986

Merged
merged 1 commit into from Nov 27, 2021
Merged

Issue #9463: update example of AST for TokenTypes.LITERAL_BOOLEAN #10986

merged 1 commit into from Nov 27, 2021

Conversation

Venkatesh-24
Copy link
Contributor

Closes: #9463

Screenshot from 2021-11-15 12-33-37

**Test.java**
public class Test { 
  public boolean flag;
}

**AST**
java -jar checkstyle-9.0.1-all.jar -t Test.java
`--CLASS_DEF -> CLASS_DEF [4:0]
    |--MODIFIERS -> MODIFIERS [4:0]
    |   `--LITERAL_PUBLIC -> public [4:0]
    |--LITERAL_CLASS -> class [4:7]
    |--IDENT -> Test [4:13]
    `--OBJBLOCK -> OBJBLOCK [4:18]
        |--LCURLY -> { [4:18]
        |--VARIABLE_DEF -> VARIABLE_DEF [5:2]
        |   |--MODIFIERS -> MODIFIERS [5:2]
        |   |   `--LITERAL_PUBLIC -> public [5:2]
        |   |--TYPE -> TYPE [5:9]
        |   |   `--LITERAL_BOOLEAN -> boolean [5:9]
        |   |--IDENT -> flag [5:17]
        |   `--SEMI -> ; [5:21]
        `--RCURLY -> } [6:0]

# Printing the code that we care
java -jar checkstyle-9.0.1-all.jar -t Test.java | grep 5:
|--VARIABLE_DEF -> VARIABLE_DEF [5:2]
|   |--MODIFIERS -> MODIFIERS [5:2]
|   |   `--LITERAL_PUBLIC -> public [5:2]
|   |--TYPE -> TYPE [5:9]
|   |   `--LITERAL_BOOLEAN -> boolean [5:9]
|   |--IDENT -> flag [5:17]
|   `--SEMI -> ; [5:21]

Expected update for javadoc

VARIABLE_DEF -> VARIABLE_DEF
  |--MODIFIERS -> MODIFIERS
  |   `--LITERAL_PUBLIC -> public
  |--TYPE -> TYPE
  |   `--LITERAL_BOOLEAN -> boolean
  |--IDENT -> flag
  `--SEMI -> ;

@Venkatesh-24
Copy link
Contributor Author

I made all the changes and ran mvn clean verify and the build was success. can you please review it @romani

@romani romani merged commit 3895bde into checkstyle:master Nov 27, 2021
@Venkatesh-24
Copy link
Contributor Author

Hi @romani can you please assign me some issue to try and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update example of AST for TokenTypes.LITERAL_BOOLEAN
2 participants