Issue #10924: Checks that use getLine() should check code points for spaces

[MUzairS15]

Closes #10924

[MUzairS15]

I also redefined hasWhitespaceBefore because it was using characters to check for spaces.
I want to understand, pls help.

[MUzairS15]

Hello, @nmancus1 Pitest are failing, on inspecting it seems like new method getCodePoints() added in AbstractCheck,and
document generated for that is creating the problem, Similarly in GenericWhiteSpaceCheck.
Not sure if my understanding is correct, can you take a look?

[MUzairS15]

How to generate regression report?
#10924 (comment)

[nrmancuso]

@MUzairS15 take a look at https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#report-generation, this section outlines report generation process. For an example, see #10838

[MUzairS15]

getLineCodePoints or getCodePointsFromLine?
Will try to solve coverage failure. Any idea on tests to achieve 100% coverage?

[redhairrs]

Sir, I am new here how can I work on this problem?

[MUzairS15]

I am already working on this.

[MUzairS15]

Still not able to meet coverage in SingleSpaceSeparator in isFirstInLine method return indexOfNonWhitespace(codePoints) >= columnNo + 1 || codePoints.length == 0 ;
and
isBlockCommentEnd. Partial coverage in both of these.

[romani]

thinks about age case that you can create in Input file to cover them, attentively read coverage report to understand what exactlt is not covered.

[MUzairS15]

I realised, I missed test for overloaded hasWhiteSpaceBefore in CommonUtil, @nmancus1 can you suggest more tests to make sure pitest passes?

[nrmancuso]

@MUzairS15 please make all other CI happy, then we will take a look at failing pitest. Also, it would be good if you could leave a "review" (comment) on any suppressions that you have added explaining why they are needed.

Edit: do not worry about failure in semaphore

[MUzairS15]

I need a empty array to be created, to test for subArray, but because of this IDEA inspection is failing. Can someone suggest how to tackle this. final int[] expected3 = new int[0];

[nrmancuso]

Few things to start with:

[nrmancuso]

Please make all code point array initializations in tests like:

      ... =  "my string here".codePoints().toArray();

Tests also serve as documentation; this will make these tests much easier to read (and write).

This should help with #10976 (comment) also.

[MUzairS15]

ok

[nrmancuso]

Let's call this CodePointUtil, since all methods deal with int/ int [] type and not String.

[MUzairS15]

Done

[romani]

@MUzairS15 , please do not resolve conversations, only author of comment can resolve them

[nrmancuso]

@MUzairS15 let's close this PR since we have decided to do separate PRs for #10924 in #10994 and others