Issue #10920: NoWhitespaceBefore error on semicolon or comma after string with emoji #10922
Conversation
|
Github, generate report |
nrmancuso
force-pushed
the
issue-10920
branch
from
2b74f50
to
f1f145d
Compare
| * @param stringArrayIndex the index of the character to check | ||
| * @return true if character at {@code stringArrayIndex} is whitespace | ||
| */ | ||
| private static boolean isCodePointWhitespace(int[] codePoints, int stringArrayIndex) { |
There was a problem hiding this comment.
I had considered adding this method to CheckUtil, but so far there is only one other possible usage in another check (WhitespaceAroundCheck).
There was a problem hiding this comment.
May be there are same issues with other whitespace checks, e.g. GenericWhitespace, NoWhitespaceBeforeCaseDefaultColon, WhitespaceAfter?
There was a problem hiding this comment.
Issue opened for further investigation at #10924
There was a problem hiding this comment.
issue is approved, lets proceed to review fix for this Check only.
There was a problem hiding this comment.
@nmancus1 , please rename stringArrayIndex to index, as it is index in codepoints array.
name method isWhitespace by argument it is clear that it is for codepoint
…a after string with emoji
nrmancuso
force-pushed
the
issue-10920
branch
from
f1f145d
to
02d532f
Compare
closes #10920 .
Diff Regression config: https://gist.githubusercontent.com/nmancus1/c505009a3aa0485a4293d193c00c807b/raw/9645b8608afd7b0dbd57df4baa2fb23cfe1802d0/config.xml