Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #10745: Added functionality for module parent #10754

Merged
merged 1 commit into from Aug 29, 2021

Conversation

shashwatj07
Copy link
Contributor

@romani
Copy link
Member

romani commented Aug 29, 2021

ok, but we need update see how this helps to resolve problem of multi modules in config. Please update at least one test method to use it as prove that it works.
You can update all others tests in next PR

@shashwatj07
Copy link
Contributor Author

shashwatj07 commented Aug 29, 2021

ok, but we need update see how this helps to resolve problem of multi modules in config. Please update at least one test method to use it as prove that it works.
You can update all others tests in next PR

It will work, I'm sure. The feedback you provided #10735 (comment) here will also blend in with this.
The only reason why I didn't implement further in this PR is because we need to remove verifyConfig now. This has to be done since we are now passing the root config to verify. I wanted to get this merged and remove verifyConfig in next PR to ensure nothing breaks.

We anyway don't need hardcoded config in test methods now. This can be a good gsoc first issue for next year.

@romani romani merged commit 71f7ced into checkstyle:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants