-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #10272: Upgrade Java Grammar from ANTLR2 to ANTLR4 #10280
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
463d763
Issue #10272: create new Antlr4AstRegressionTest with inputs and expe…
nrmancuso 59ab5cc
Issue #10272: infra and dependencies
nrmancuso 969648e
Issue #10272: suppressions and configs
nrmancuso 511de07
Issue #10272: update tests for antlr4 (tokens, exceptions, etc.)
nrmancuso 566094f
Issue #10272: update utilities
nrmancuso d3e5ee9
Issue #10272: update ArrayTypeStyleCheck
nrmancuso 3f6281c
Issue #10272: update WhitespaceAfterCheck
nrmancuso 3d471c3
Issue #10272: Upgrade Java Grammar from ANTLR2 to ANTLR4
nrmancuso File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/main/java/com/puppycrawl/tools/checkstyle/CheckstyleParserErrorStrategy.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
//////////////////////////////////////////////////////////////////////////////// | ||
// checkstyle: Checks Java source code for adherence to a set of rules. | ||
// Copyright (C) 2001-2021 the original author or authors. | ||
// | ||
// This library is free software; you can redistribute it and/or | ||
// modify it under the terms of the GNU Lesser General Public | ||
// License as published by the Free Software Foundation; either | ||
// version 2.1 of the License, or (at your option) any later version. | ||
// | ||
// This library is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
// Lesser General Public License for more details. | ||
// | ||
// You should have received a copy of the GNU Lesser General Public | ||
// License along with this library; if not, write to the Free Software | ||
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
//////////////////////////////////////////////////////////////////////////////// | ||
|
||
package com.puppycrawl.tools.checkstyle; | ||
|
||
import org.antlr.v4.runtime.BailErrorStrategy; | ||
import org.antlr.v4.runtime.InputMismatchException; | ||
import org.antlr.v4.runtime.Parser; | ||
import org.antlr.v4.runtime.Token; | ||
|
||
/** | ||
* Extending BailErrorStrategy allows us to report errors while | ||
* cancelling the parsing operation. If input is not syntactically | ||
* correct, we do not need to use antlr's recovery strategy, which | ||
* can add significant overhead. | ||
* | ||
*/ | ||
public class CheckstyleParserErrorStrategy extends BailErrorStrategy { | ||
|
||
@Override | ||
public Token recoverInline(Parser recognizer) { | ||
reportError(recognizer, new InputMismatchException(recognizer)); | ||
return super.recoverInline(recognizer); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this to it's own class since we share this error strategy with both (Java and Javadoc) parsers now.