Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pitest Issues - JavadocMethodCheck (5) #7977

Closed
rnveach opened this issue Mar 28, 2020 · 4 comments
Closed

Resolve Pitest Issues - JavadocMethodCheck (5) #7977

rnveach opened this issue Mar 28, 2020 · 4 comments

Comments

@rnveach
Copy link
Member

rnveach commented Mar 28, 2020

Child issue of #7797 ,

"JavadocMethodCheck.java.html:<td class='covered'><pre><span class='survived'> if (classInfo != null) {</span></pre></td></tr>"

@HuGanghui
Copy link
Contributor

I am on it.

@HuGanghui
Copy link
Contributor

HuGanghui commented Apr 16, 2020

Pitest report

Link: https://huganghui.github.io/7977-JavadocMethodCheck-5/before-pitest-reports/com.puppycrawl.tools.checkstyle.checks.javadoc/JavadocMethodCheck.java.html#grouporg.pitest.mutationtest.report.html.SourceFile@1353848a_1077

Surviving mutations:
on line 1077: negated conditional → SURVIVED

Hardcoded mutation

mutation cs branch: HuGanghui@f5642b3
comment:
Looking at the pitest report, we can see that the surviving mutation is negated conditional → SURVIVED, so I change != -> == .

Regression diff report
https://huganghui.github.io//7977-JavadocMethodCheck-5/hardcoded-reports/diff/
there is no diff found.

Code Logic Analysis
Although there is no diff found in Regression diff report, I find that containing class ClassAlias and its relevant code is redundant, which also is mentioned in issue #7980 by @rnveach. So I do a diff report https://huganghui.github.io//7977-JavadocMethodCheck-5/remove-redundant-reports/diff/ on a branch(HuGanghui@20ad567) that remove class ClassAlias and its relevant code and result is no diff found. I also do Pitest after removing redundant code report show that it doesn't introduce new surviving mutations and solve all JavadocMethodCheck Pitest mutations including #7923, #7924, #7925, this issue, #7979, #7980 and Based on this result, I think maybe we can remove redundant code~

@HuGanghui
Copy link
Contributor

@rnveach please review

@rnveach
Copy link
Member Author

rnveach commented May 19, 2020

fixed in scope of #7980

@rnveach rnveach closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants