New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Pitest for profile coding-2 #12331
Comments
I recommend to keep each mutation separately to not block easy mutations. Or at least send separate PRs |
@romani @rnveach for https://checkstyle.org/config_coding.html#FinalLocalVariable
I have a doubt here should we really expect violation in constructor here |
@Kevin222004 Why do you doubt?
|
it might be lack of my knowledge i have not seen this type of code before that's why
|
…o kill mutation
Yes, in general, modifiers on parameters have fallen out of favor, especially with the advent of static analysis/IDEs that will flag reassigned parameters for you. However, this code is still valid. |
…o kill mutation
…o kill mutation
Code can exist in real code, there might be some crazy reason to keep it like this. |
…ntrolVariableCheck
…ntrolVariableCheck
…ntrolVariableCheck
@rnveach in this issue all the mutation except
and
has been killed can you please help with this this is the different one may be, according to pit the Lines 269 to 284 in 811983e
in this method case value 138 and 139 is mutated but their is no any token type defined in code which value is 138 and 139 |
Does it look related to hcoles/pitest#1137 . Does the specific cases go in the default? |
Yes it is looking somewhere like hcoles/pitest#1137. the two extra cases which are not available in code they are not giving test failure in default as well in without default case |
@Kevin222004 what do we have left to do to close this issue? |
@nrmancuso According to the issue description part-2 and part-3 has been done but in part 1 |
there is not such survivals any more in project, see referenced commits or PR in project on how it was fixed |
Related to #7797
kill mutation:-
part - 1
checkstyle/.ci/pitest-suppressions/pitest-coding-2-suppressions.xml
Lines 3 to 28 in aad6891
and
part - 2
checkstyle/.ci/pitest-suppressions/pitest-coding-2-suppressions.xml
Lines 84 to 91 in aad6891
and
part - 3
checkstyle/.ci/pitest-suppressions/pitest-coding-2-suppressions.xml
Lines 174 to 370 in aad6891
The text was updated successfully, but these errors were encountered: