Issue #12326: Resolve Pitest suppression for AccessModifierOption

checkstyle · Nov 23, 2022 · edd2b09 · edd2b09
1 parent 3c1c029
commit edd2b09
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 9 deletions.
diff --git a/.ci/pitest-suppressions/pitest-naming-suppressions.xml b/.ci/pitest-suppressions/pitest-naming-suppressions.xml
@@ -9,15 +9,6 @@
     <lineContent>curNode = curNode.getNextSibling();</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>AccessModifierOption.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.naming.AccessModifierOption</mutatedClass>
-    <mutatedMethod>getInstance</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
-    <description>replaced call to java/lang/String::trim with receiver</description>
-    <lineContent>return valueOf(AccessModifierOption.class, modifierName.trim().toUpperCase(Locale.ENGLISH));</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>ParameterNameCheck.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.naming.ParameterNameCheck</mutatedClass>

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
@@ -68,6 +68,17 @@ public void testSpecified()
                 getPath("InputParameterNameOne.java"), expected);
     }
 
+    @Test
+    public void testWhitespaceInAccessModifierProperty() throws Exception {
+        final String pattern = "^h$";
+        final String[] expected = {
+            "14:69: " + getCheckMessage(MSG_INVALID_PATTERN, "parameter1", pattern),
+            "18:31: " + getCheckMessage(MSG_INVALID_PATTERN, "parameter2", pattern),
+        };
+        verifyWithInlineConfigParser(
+                getPath("InputParameterNameWhitespaceInAccessModifierProperty.java"), expected);
+    }
+
     @Test
     public void testDefault()
             throws Exception {

diff --git a/...yle/checks/naming/parametername/InputParameterNameWhitespaceInAccessModifierProperty.java b/...yle/checks/naming/parametername/InputParameterNameWhitespaceInAccessModifierProperty.java
@@ -0,0 +1,23 @@
+/*
+ParameterName
+format = ^h$
+ignoreOverridden = (default)false
+accessModifiers = \tpublic
+
+
+*/
+
+package com.puppycrawl.tools.checkstyle.checks.naming.parametername;
+
+public class InputParameterNameWhitespaceInAccessModifierProperty {
+
+    public InputParameterNameWhitespaceInAccessModifierProperty(int parameter1) {} // violation
+
+    public void v1(int h) { // ok
+        new Object () {
+            public void i(int parameter2) {} // violation
+        };
+    }
+
+    void method2(int V3) {}
+}