Issue #6381: Incorrect warning for empty lambda bodies with google_ch…

…ecks.xml
checkstyle · Feb 20, 2019 · 88907c5 · 88907c5
1 parent cb46811
commit 88907c5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/config/suppressions.xml b/config/suppressions.xml
@@ -6,7 +6,7 @@
 
 <suppressions>
     <!-- can't split long messages between lines -->
-    <suppress checks="RegexpSingleline" files="google_checks\.xml" lines="37,77"/>
+    <suppress checks="RegexpSingleline" files="google_checks\.xml" lines="37,78"/>
 
     <suppress checks="FileLength"
               files="TokenTypes.java|IndentationCheckTest.java"

diff --git a/.../checkstyle/test/chapter4formatting/rule462horizontalwhitespace/WhitespaceAroundTest.java b/.../checkstyle/test/chapter4formatting/rule462horizontalwhitespace/WhitespaceAroundTest.java
@@ -64,7 +64,6 @@ public void testWhitespaceAroundBasic() throws Exception {
             "150:20: " + getCheckMessage(messages, msgPreceded, ":"),
             "249:14: " + getCheckMessage(messages, msgPreceded, "->"),
             "250:15: " + getCheckMessage(messages, msgFollowed, "->"),
-            "250:17: " + getCheckMessage(messages, msgPreceded, "{"),
         };
 
         final String filePath = getPath("InputWhitespaceAroundBasic.java");

diff --git a/...style/test/chapter4formatting/rule462horizontalwhitespace/InputWhitespaceAroundBasic.java b/...style/test/chapter4formatting/rule462horizontalwhitespace/InputWhitespaceAroundBasic.java
@@ -248,7 +248,8 @@ class NewGoogleOperators
 
        l = ()-> { }; //warn
        l = () ->{ }; //warn
-       l = () -> { };
+       l = () -> { }; //ok
+       l = () -> {}; //ok
 
        java.util.Arrays.sort(null, String :: compareToIgnoreCase);
        java.util.Arrays.sort(null, String::compareToIgnoreCase);

diff --git a/src/main/resources/google_checks.xml b/src/main/resources/google_checks.xml
@@ -70,6 +70,7 @@
         </module>
         <module name="WhitespaceAround">
             <property name="allowEmptyConstructors" value="true"/>
+            <property name="allowEmptyLambdas" value="true"/>
             <property name="allowEmptyMethods" value="true"/>
             <property name="allowEmptyTypes" value="true"/>
             <property name="allowEmptyLoops" value="true"/>