Issue #5899: Add InterfaceImpliedModifierCheck

checkstyle · Jun 30, 2018 · 7133214 · 7133214
1 parent fc0f5e3
commit 7133214
Show file tree

Hide file tree

Showing 29 changed files with 1,442 additions and 3 deletions.
diff --git a/.ci/jsoref-spellchecker/whitelist.words b/.ci/jsoref-spellchecker/whitelist.words
@@ -582,6 +582,7 @@ Intelli
 intellij
 intercell
 interfaceistype
+interfacememberimpliedmodifier
 interfacetypeparametername
 invalidformat
 invalidinherit

diff --git a/config/checkstyle_checks.xml b/config/checkstyle_checks.xml
@@ -488,6 +488,10 @@
     <!-- Modifiers -->
     <module name="ModifierOrder"/>
     <module name="RedundantModifier"/>
+    <module name="InterfaceMemberImpliedModifier">
+      <!-- effectively the opposite of RedundantModifier, so output must be ignored -->
+      <property name="severity" value="ignore"/>
+    </module>
 
     <!-- Naming Conventions -->
     <module name="AbbreviationAsWordInName">

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java b/src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java
@@ -668,6 +668,8 @@ private static void fillChecksFromMetricsPackage() {
      * Fill short-to-full module names map with Checks from modifier package.
      */
     private static void fillChecksFromModifierPackage() {
+        NAME_TO_FULL_MODULE_NAME.put("InterfaceMemberImpliedModifierCheck",
+            BASE_PACKAGE + ".checks.modifier.InterfaceMemberImpliedModifierCheck");
         NAME_TO_FULL_MODULE_NAME.put("ModifierOrderCheck",
                 BASE_PACKAGE + ".checks.modifier.ModifierOrderCheck");
         NAME_TO_FULL_MODULE_NAME.put("RedundantModifierCheck",