Issue #12164: Enable Checker Framework

.ci/StarterRuleSet-AllRulesByCategory.groovy.txt

@@ -359,9 +359,6 @@ ruleset {
     NonFinalSubclassOfSensitiveInterface
     ObjectFinalize
     PublicFinalizeMethod
-    SystemExit {
-        doNotApplyToFileNames = 'pitest-survival-check-xml.groovy,error-prone-check.groovy'
-    }
     UnsafeArrayDeclaration
 
     // rulesets/serialization.xml

.ci/checker-framework-suppressions/checker-framework-formatter-suppressions.xml

@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<suppressedErrors>
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/DefaultLogger.java</fileName>
+    <specifier>i18nformat.key.not.found</specifier>
+    <message>a key doesn&apos;t exist in the provided translation file</message>
+    <lineContent>final String pattern = resourceBundle.getString(key);</lineContent>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/Violation.java</fileName>
+    <specifier>i18nformat.key.not.found</specifier>
+    <message>a key doesn&apos;t exist in the provided translation file</message>
+    <lineContent>final String pattern = resourceBundle.getString(key);</lineContent>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/meta/JavadocMetadataScraper.java</fileName>
+    <specifier>format.string</specifier>
+    <message>invalid format string (is a @Format annotation missing?)</message>
+    <lineContent>Locale.ROOT, PROP_DEFAULT_VALUE_MISSING, propertyName)</lineContent>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/meta/JavadocMetadataScraper.java</fileName>
+    <specifier>format.string</specifier>
+    <message>invalid format string (is a @Format annotation missing?)</message>
+    <lineContent>Locale.ROOT, PROP_TYPE_MISSING, propertyName)</lineContent>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
+    <specifier>i18nformat.key.not.found</specifier>
+    <message>a key doesn&apos;t exist in the provided translation file</message>
+    <lineContent>return bundle.getString(name);</lineContent>
+  </checkerFrameworkError>
+</suppressedErrors>

.ci/checker-framework-suppressions/checker-framework-purity-value-returns-suppressions.xml

@@ -0,0 +1,61 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<suppressedErrors>
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/CheckUtil.java</fileName>
+    <specifier>argument</specifier>
+    <message>incompatible argument for parameter radix of parseInt.</message>
+    <lineContent>result = Integer.parseInt(txt, radix);</lineContent>
+    <details>
+      found   : int
+      required: @IntRange(from=2, to=36) int
+    </details>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/CheckUtil.java</fileName>
+    <specifier>argument</specifier>
+    <message>incompatible argument for parameter radix of parseLong.</message>
+    <lineContent>result = Long.parseLong(txt, radix);</lineContent>
+    <details>
+      found   : int
+      required: @IntRange(from=2, to=36) int
+    </details>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/CheckUtil.java</fileName>
+    <specifier>argument</specifier>
+    <message>incompatible argument for parameter radix of parseUnsignedInt.</message>
+    <lineContent>result = Integer.parseUnsignedInt(txt, radix);</lineContent>
+    <details>
+      found   : int
+      required: @IntRange(from=2, to=36) int
+    </details>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/CheckUtil.java</fileName>
+    <specifier>argument</specifier>
+    <message>incompatible argument for parameter radix of parseUnsignedLong.</message>
+    <lineContent>result = Long.parseUnsignedLong(txt, radix);</lineContent>
+    <details>
+      found   : int
+      required: @IntRange(from=2, to=36) int
+    </details>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
+    <specifier>methodref.param</specifier>
+    <message>Incompatible parameter type for bitIndex</message>
+    <lineContent>.collect(BitSet::new, BitSet::set, BitSet::or);</lineContent>
+    <details>
+      found   : @IntRangeFromNonNegative int
+      required: int
+      Consequence: method in BitSet
+      void set(BitSet this, @IntRangeFromNonNegative int p0)
+      is not a valid method reference for method in ObjIntConsumer&lt;BitSet&gt;
+      void accept(ObjIntConsumer&lt;BitSet&gt; this, BitSet p0, int p1)
+    </details>
+  </checkerFrameworkError>
+</suppressedErrors>