Skip to content

Commit

Permalink
Issue #8019: Partially Resolved and partially suppressed FileTabChara…
Browse files Browse the repository at this point in the history
…cter violations
  • Loading branch information
shashwatj07 authored and romani committed May 28, 2020
1 parent cede38a commit 6275303
Show file tree
Hide file tree
Showing 65 changed files with 1,036 additions and 964 deletions.
2 changes: 0 additions & 2 deletions config/checkstyle_resources_checks.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
<property name="file"
value="${project.basedir}/config/checkstyle_resources_suppressions.xml"/>
</module>
<!-- until https://github.com/checkstyle/checkstyle/issues/8019
<module name="FileTabCharacter"/>
-->
<module name="RegexpSingleline">
<property name="format" value="\s+$"/>
<property name="message" value="Trailing whitespace"/>
Expand Down
74 changes: 74 additions & 0 deletions config/checkstyle_resources_suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,78 @@
<suppress checks="RegexpSingleline"
files="[\\/]InputJavadocTagContinuationIndentationGuavaFalsePositive\.java"/>

<!-- intentional problem for testing -->
<suppress checks="FileTabCharacter"
files="[\\/]InputJavadocWithCrAsNewline\.javadoc"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputLeadingAsterisksExtended\.javadoc"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputListWithUnclosedItemInUnclosedParagraph\.javadoc"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputMixedCaseOfHtmlTags\.javadoc"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputUnclosedParagraphFollowedByJavadocTag\.javadoc"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputFileTabCharacter\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputMainGenerateXpathSuppressionsTabWidth\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputXpathQueryGeneratorTabWidth\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputFileTabCharacterSimple\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputIndentationUseTabs\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputCheckerTabCharacter\.txt"/>
<suppress checks="FileTabCharacter"
files="src[\\/]test[\\/]resources[\\/]com[\\/]puppycrawl[\\/]tools[\\/]checkstyle[\\/]checks[\\/]indentation[\\/]indentation[\\/]Input.*\.java"/>
<suppress checks="FileTabCharacter"
files="src[\\/]test[\\/]resources[\\/]com[\\/]puppycrawl[\\/]tools[\\/]checkstyle[\\/]filters[\\/]suppresswithplaintextcommentfilter[\\/]Input.*"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputRegressionJavaClass1\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputComments2\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputMainSuppressionsStringPrinter\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputXpathFileGeneratorAstFilter\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputNoLineWrapBad\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputAstTreeStringPrinterFullOfBlockComments\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputAstTreeStringPrinterJavadocPosition\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputAstTreeStringPrinterComments\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputIllegalInstantiationLang\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputMagicNumberAnnotationElement\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputInnerTypeLastClass\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputJavadocStyle\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputJavadocMissingWhitespaceAfterAsteriskValidWithTab\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputAbbreviationAsWordInNameOverridableMethod\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputAbbreviationAsWordInNameType\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputLineLengthSimple\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputTodoCommentSimple\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputWhitespaceAroundSimple\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputWhitespaceAroundEmptyTypesAndCycles\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputWhitespaceAfterDefaultConfig\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputSingleSpaceSeparatorComments\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputSingleSpaceSeparatorErrors\.java"/>
<suppress checks="FileTabCharacter"
files="[\\/]InputParenPadWhitespace\.java"/>

</suppressions>
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
import java.util.Scanner;

public class SuppressionXpathRegressionCustomImportOrderFive {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
import java.util.Scanner;

public class SuppressionXpathRegressionCustomImportOrderFour {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
import java.util.Scanner;

public class SuppressionXpathRegressionCustomImportOrderOne {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
import java.util.Scanner;

public class SuppressionXpathRegressionCustomImportOrderSix {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
import java.util.Scanner;

public class SuppressionXpathRegressionCustomImportOrderThree {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
import java.util.Scanner;

public class SuppressionXpathRegressionCustomImportOrderTwo {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
import java.util.Date; // warn

public class SuppressionXpathRegressionImportOrderFive {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
import static java.lang.Math.PI; // warn

public class SuppressionXpathRegressionImportOrderFour {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
import java.util.Set; // warn

public class SuppressionXpathRegressionImportOrderOne {
// code
// code
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
import java.util.Set; // warn

public class SuppressionXpathRegressionImportOrderTwo {
// code
// code
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package org.checkstyle.suppressionxpathfilter.invalidjavadocposition;

public class SuppressionXpathRegressionInvalidJavadocPositionSix {
int a;
int a;
/** // warn
* Javadoc Comment
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@


import java .
net.Socket ;
net.Socket ;

public class InputCustomImportOrderViolationsSameLine {}

0 comments on commit 6275303

Please sign in to comment.