Issue #7405: all new checks should have XpathRegressionTest

config/intellij-idea-inspections.xml

@@ -4610,6 +4610,7 @@
     ,org.mockito.InOrder,verify, ,
     ,org.junit.rules.ExpectedException,expect.*, ,
     ,org.hamcrest.MatcherAssert,assertThat, ,
+    ,com.google.common.truth.Truth,assert.*, ,
     ,com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport,verify.*, ,
     ,com.puppycrawl.tools.checkstyle.AbstractTreeTestSupport,verify.*, ,
     ,com.google.checkstyle.test.base.AbstractModuleTestSupport,verify.*, ,

src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionXpathFilter.java

@@ -40,304 +40,187 @@
  * suppressed nodes inside the AST tree.
  * </p>
  * <p>
- * Currently, filter supports the following checks:
+ * Currently, filter does not support the following checks:
  * </p>
- * <ul>
- * <li>
- * AbbreviationAsWordInName
- * </li>
- * <li>
- * AbstractClassName
- * </li>
- * <li>
- * AnonInnerLength
- * </li>
- * <li>
- * ArrayTypeStyle
- * </li>
- * <li>
- * AvoidInlineConditionals
- * </li>
- * <li>
- * AvoidNestedBlocks
- * </li>
- * <li>
- * BooleanExpressionComplexity
- * </li>
- * <li>
- * CatchParameterName
- * </li>
- * <li>
- * ClassDataAbstractionCoupling
- * </li>
- * <li>
- * ClassFanOutComplexity
- * </li>
- * <li>
- * ClassMemberImpliedModifier
- * </li>
- * <li>
- * ClassTypeParameterName
- * </li>
- * <li>
- * ConstantName
- * </li>
- * <li>
- * CovariantEquals
- * </li>
- * <li>
- * CyclomaticComplexity
- * </li>
- * <li>
- * DeclarationOrder
- * </li>
- * <li>
- * DefaultComesLast
- * </li>
- * <li>
- * DescendantToken
- * </li>
- * <li>
- * DesignForExtension
- * </li>
- * <li>
- * EmptyBlock
- * </li>
- * <li>
- * EmptyForInitializerPad
- * </li>
+ * <ul id="SuppressionXpathFilter_IncompatibleChecks">
  * <li>
- * EmptyForIteratorPad
+ * AnnotationLocation
  * </li>
  * <li>
- * EmptyStatement
+ * AnnotationOnSameLine
  * </li>
  * <li>
- * EqualsAvoidNull
+ * AnnotationUseStyle
  * </li>
  * <li>
- * EqualsHashCode
+ * ArrayTrailingComma
  * </li>
  * <li>
- * ExecutableStatementCount
+ * AvoidEscapedUnicodeCharacters
  * </li>
  * <li>
- * ExplicitInitialization
+ * AvoidStarImport
  * </li>
  * <li>
- * FallThrough
+ * AvoidStaticImport
  * </li>
  * <li>
- * FinalLocalVariable
+ * CommentsIndentation
  * </li>
  * <li>
- * FinalParameters
+ * CustomImportOrder
  * </li>
  * <li>
- * GenericWhitespace
+ * EmptyCatchBlock
  * </li>
  * <li>
- * HiddenField
+ * EmptyLineSeparator
  * </li>
  * <li>
- * HideUtilityClassConstructor
+ * FinalClass
  * </li>
  * <li>
- * IllegalInstantiation
+ * IllegalCatch
  * </li>
  * <li>
- * IllegalToken
+ * ImportOrder
  * </li>
  * <li>
- * IllegalTokenText
+ * Indentation
  * </li>
  * <li>
- * IllegalType
+ * InterfaceIsType
  * </li>
  * <li>
- * InnerAssignment
+ * InterfaceMemberImpliedModifier
  * </li>
  * <li>
- * InnerTypeLast
+ * InvalidJavadocPosition
  * </li>
  * <li>
- * InterfaceTypeParameterName
+ * JavadocContentLocation
  * </li>
  * <li>
- * JavadocVariable
+ * JavadocMethod
  * </li>
  * <li>
- * JavaNCSS
+ * JavadocStyle
  * </li>
  * <li>
- * IllegalImport
+ * JavadocType
  * </li>
  * <li>
- * IllegalThrows
+ * LambdaParameterName
  * </li>
  * <li>
- * ImportControl
+ * MethodCount
  * </li>
  * <li>
- * LeftCurly
+ * MissingCtor
  * </li>
  * <li>
- * LocalFinalVariableName
+ * MissingJavadocMethod
  * </li>
  * <li>
- * LocalVariableName
+ * MissingJavadocPackage
  * </li>
  * <li>
- * MagicNumber
+ * MissingJavadocType
  * </li>
  * <li>
- * MemberName
+ * MissingOverride
  * </li>
  * <li>
- * MethodLength
+ * MissingSwitchDefault
  * </li>
  * <li>
- * MethodName
+ * NeedBraces
  * </li>
  * <li>
- * MethodParamPad
+ * NoClone
  * </li>
  * <li>
- * MethodTypeParameterName
+ * NoFinalizer
  * </li>
  * <li>
- * ModifiedControlVariable
+ * NoLineWrap
  * </li>
  * <li>
- * ModifierOrder
+ * OneTopLevelClass
  * </li>
  * <li>
- * MultipleStringLiterals
+ * OuterTypeFilename
  * </li>
  * <li>
- * MultipleVariableDeclarations
+ * OverloadMethodsDeclarationOrder
  * </li>
  * <li>
- * MutableException
+ * PackageAnnotation
  * </li>
  * <li>
- * NestedForDepth
+ * PackageDeclaration
  * </li>
  * <li>
- * NestedIfDepth
+ * Regexp
  * </li>
  * <li>
- * NestedTryDepth
+ * RegexpSinglelineJava
  * </li>
  * <li>
- * NoWhitespaceAfter
+ * SuppressWarningsHolder
  * </li>
  * <li>
- * NoWhitespaceBefore
+ * TodoComment
  * </li>
  * <li>
- * NPathComplexity
+ * TrailingComment
  * </li>
  * <li>
- * OneStatementPerLine
+ * UncommentedMain
  * </li>
  * <li>
- * OperatorWrap
+ * UnnecessaryParentheses
  * </li>
  * <li>
- * OuterTypeNumber
+ * VariableDeclarationUsageDistance
  * </li>
  * <li>
- * PackageName
- * </li>
- * <li>
- * ParameterAssignment
- * </li>
- * <li>
- * ParameterName
- * </li>
- * <li>
- * ParameterNumber
- * </li>
- * <li>
- * ParenPad
- * </li>
- * <li>
- * RedundantImport
- * </li>
- * <li>
- * RedundantModifier
- * </li>
- * <li>
- * RequireThis
- * </li>
- * <li>
- * ReturnCount
- * </li>
- * <li>
- * RightCurly
- * </li>
- * <li>
- * SeparatorWrap
- * </li>
- * <li>
- * SimplifyBooleanExpression
- * </li>
- * <li>
- * SimplifyBooleanReturn
- * </li>
- * <li>
- * SingleSpaceSeparator
- * </li>
- * <li>
- * StaticVariableName
- * </li>
- * <li>
- * StringLiteralEquality
- * </li>
- * <li>
- * SuperClone
- * </li>
- * <li>
- * SuperFinalize
- * </li>
- * <li>
- * SuppressWarnings
- * </li>
- * <li>
- * ThrowsCount
- * </li>
- * <li>
- * TypecastParenPad
+ * WriteTag
  * </li>
+ * </ul>
+ * <p>
+ * Also, the filter does not support Javadoc checks:
+ * </p>
+ * <ul id="SuppressionXpathFilter_JavadocChecks">
  * <li>
- * TypeName
+ * AtclauseOrder
  * </li>
  * <li>
- * UnnecessarySemicolonInEnumeration
+ * JavadocBlockTagLocation
  * </li>
  * <li>
- * UnnecessarySemicolonInTryWithResources
+ * JavadocParagraph
  * </li>
  * <li>
- * UnusedImports
+ * JavadocTagContinuationIndentation
  * </li>
  * <li>
- * UpperEll
+ * MissingDeprecated
  * </li>
  * <li>
- * VisibilityModifier
+ * NonEmptyAtclauseDescription
  * </li>
  * <li>
- * WhitespaceAfter
+ * SingleLineJavadoc
  * </li>
  * <li>
- * WhitespaceAround
+ * SummaryJavadoc
  * </li>
  * </ul>
  * <p>
- * Note, that support for other Checks will be available after resolving
- * <a href="https://github.com/checkstyle/checkstyle/issues/4830">issue 4830</a>.
+ * Note, that support for these Checks will be available after resolving issues
+ * <a href="https://github.com/checkstyle/checkstyle/issues/5770">#5770</a> and
+ * <a href="https://github.com/checkstyle/checkstyle/issues/5777">#5777</a>.
  * </p>
  * <p>
  * Currently, filter supports the following xpath axes: