dependency: bump checkerframework.version from 3.42.0 to 3.43.0

Bumps `checkerframework.version` from 3.42.0 to 3.43.0. Updates `org.checkerframework:checker-qual` from 3.42.0 to 3.43.0 - [Release notes](https://github.com/typetools/checker-framework/releases) - [Changelog](https://github.com/typetools/checker-framework/blob/master/docs/CHANGELOG.md) - [Commits](typetools/checker-framework@checker-framework-3.42.0...checker-framework-3.43.0) Updates `org.checkerframework:checker` from 3.42.0 to 3.43.0 - [Release notes](https://github.com/typetools/checker-framework/releases) - [Changelog](https://github.com/typetools/checker-framework/blob/master/docs/CHANGELOG.md) - [Commits](typetools/checker-framework@checker-framework-3.42.0...checker-framework-3.43.0) --- updated-dependencies: - dependency-name: org.checkerframework:checker-qual dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.checkerframework:checker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
checkstyle · May 11, 2024 · 391dee4 · 391dee4
1 parent 6d64b16
commit 391dee4
Show file tree

Hide file tree

Showing 5 changed files with 216 additions and 178 deletions.
diff --git a/config/checker-framework-suppressions/checker-lock-tainting-suppressions.xml b/config/checker-framework-suppressions/checker-lock-tainting-suppressions.xml
@@ -89,7 +89,7 @@
     <details>
       found   : @GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy String&gt;
       required: @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy String&gt;
-      Consequence: method in @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy String&gt;
+      Consequence: method in @GuardedBy Entry&lt;K extends @GuardedBy Object, V extends @GuardedBy Object&gt;
       @GuardedBy String getKey(@GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy String&gt; this)
       is not a valid method reference for method in @GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy String&gt;, @GuardedBy String&gt;
       @GuardedBy String apply(@GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy String&gt;, @GuardedBy String&gt; this, @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy String&gt; p0)
@@ -439,16 +439,11 @@
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java</fileName>
-    <specifier>methodref.param</specifier>
-    <message>Incompatible parameter type for obj</message>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.iterate</message>
     <lineContent>Stream.iterate(startNode.getLastChild(), Objects::nonNull,</lineContent>
     <details>
-      found   : @GuardSatisfied Object
-      required: @GuardedBy DetailAST
-      Consequence: method in @GuardedBy Objects
-      @GuardedBy boolean nonNull(@GuardSatisfied Object p0)
-      is not a valid method reference for method in @GuardedBy Predicate&lt;@GuardedBy DetailAST&gt;
-      @GuardedBy boolean test(@GuardedBy Predicate&lt;@GuardedBy DetailAST&gt; this, @GuardedBy DetailAST p0)
+      unsatisfiable constraint: @GuardedBy DetailAST &lt;: @GuardSatisfied Object
     </details>
   </checkerFrameworkError>
 
@@ -505,7 +500,7 @@
     <details>
       found   : @GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt;
       required: @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt;
-      Consequence: method in @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt;
+      Consequence: method in @GuardedBy Entry&lt;K extends @GuardedBy Object, V extends @GuardedBy Object&gt;
       @GuardedBy ClassDesc getValue(@GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt; this)
       is not a valid method reference for method in @GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt;, @GuardedBy ClassDesc&gt;
       @GuardedBy ClassDesc apply(@GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt;, @GuardedBy ClassDesc&gt; this, @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy ClassDesc&gt; p0)
@@ -543,16 +538,11 @@
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java</fileName>
-    <specifier>methodref.param</specifier>
-    <message>Incompatible parameter type for obj</message>
-    <lineContent>.map(String::valueOf)</lineContent>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.collect</message>
+    <lineContent>.collect(Collectors.joining(&quot;, &quot;)),</lineContent>
     <details>
-      found   : @GuardSatisfied Object
-      required: @GuardedBy Integer
-      Consequence: method in @GuardedBy String
-      @NewObject String valueOf(@GuardSatisfied Object p0)
-      is not a valid method reference for method in @GuardedBy Function&lt;@GuardedBy Integer, @GuardedBy String&gt;
-      @GuardedBy String apply(@GuardedBy Function&lt;@GuardedBy Integer, @GuardedBy String&gt; this, @GuardedBy Integer p0)
+      unsatisfiable constraint: @GuardedBy String &lt;: @GuardSatisfied Object
     </details>
   </checkerFrameworkError>
 
@@ -669,16 +659,11 @@
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodLengthCheck.java</fileName>
-    <specifier>methodref.param</specifier>
-    <message>Incompatible parameter type for obj</message>
-    <lineContent>node.getLastChild(), Objects::nonNull, DetailAST::getPreviousSibling</lineContent>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.iterate</message>
+    <lineContent>Stream.iterate(</lineContent>
     <details>
-      found   : @GuardSatisfied Object
-      required: @GuardedBy DetailAST
-      Consequence: method in @GuardedBy Objects
-      @GuardedBy boolean nonNull(@GuardSatisfied Object p0)
-      is not a valid method reference for method in @GuardedBy Predicate&lt;@GuardedBy DetailAST&gt;
-      @GuardedBy boolean test(@GuardedBy Predicate&lt;@GuardedBy DetailAST&gt; this, @GuardedBy DetailAST p0)
+      unsatisfiable constraint: @GuardedBy DetailAST &lt;: @GuardSatisfied Object
     </details>
   </checkerFrameworkError>
 
@@ -1329,59 +1314,59 @@
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
     <specifier>methodref.receiver</specifier>
     <message>Incompatible receiver type</message>
-    <lineContent>.collect(BitSet::new, BitSet::set, BitSet::or);</lineContent>
+    <lineContent>.collect(Collectors.toUnmodifiableMap(Map.Entry::getValue, Map.Entry::getKey));</lineContent>
     <details>
-      found   : @GuardSatisfied BitSet
-      required: @GuardedBy BitSet
-      Consequence: method in @GuardedBy BitSet
-      void or(@GuardSatisfied BitSet this, @GuardedBy BitSet p0)
-      is not a valid method reference for method in @GuardedBy BiConsumer&lt;@GuardedBy BitSet, @GuardedBy BitSet&gt;
-      void accept(@GuardedBy BiConsumer&lt;@GuardedBy BitSet, @GuardedBy BitSet&gt; this, @GuardedBy BitSet p0, @GuardedBy BitSet p1)
+      found   : @GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;
+      required: @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;
+      Consequence: method in @GuardedBy Entry&lt;K extends @GuardedBy Object, V extends @GuardedBy Object&gt;
+      @GuardedBy Integer getValue(@GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy Integer&gt; this)
+      is not a valid method reference for method in @GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;, @GuardedBy Integer&gt;
+      @GuardedBy Integer apply(@GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;, @GuardedBy Integer&gt; this, @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt; p0)
     </details>
   </checkerFrameworkError>
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
     <specifier>methodref.receiver</specifier>
     <message>Incompatible receiver type</message>
-    <lineContent>.collect(BitSet::new, BitSet::set, BitSet::or);</lineContent>
+    <lineContent>.collect(Collectors.toUnmodifiableMap(Map.Entry::getValue, Map.Entry::getKey));</lineContent>
     <details>
-      found   : @GuardSatisfied BitSet
-      required: @GuardedBy BitSet
-      Consequence: method in @GuardedBy BitSet
-      void or(@GuardSatisfied BitSet this, @GuardedBy BitSet p0)
-      is not a valid method reference for method in @GuardedBy BiConsumer&lt;@GuardedBy BitSet, @GuardedBy BitSet&gt;
-      void accept(@GuardedBy BiConsumer&lt;@GuardedBy BitSet, @GuardedBy BitSet&gt; this, @GuardedBy BitSet p0, @GuardedBy BitSet p1)
+      found   : @GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;
+      required: @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;
+      Consequence: method in @GuardedBy Entry&lt;K extends @GuardedBy Object, V extends @GuardedBy Object&gt;
+      @GuardedBy String getKey(@GuardSatisfied Entry&lt;@GuardedBy String, @GuardedBy Integer&gt; this)
+      is not a valid method reference for method in @GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;, @GuardedBy String&gt;
+      @GuardedBy String apply(@GuardedBy Function&lt;@GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt;, @GuardedBy String&gt; this, @GuardedBy Entry&lt;@GuardedBy String, @GuardedBy Integer&gt; p0)
     </details>
   </checkerFrameworkError>
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
-    <specifier>methodref.receiver</specifier>
-    <message>Incompatible receiver type</message>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for IntStream.collect</message>
     <lineContent>.collect(BitSet::new, BitSet::set, BitSet::or);</lineContent>
     <details>
-      found   : @GuardSatisfied BitSet
-      required: @GuardedBy BitSet
-      Consequence: method in @GuardedBy BitSet
-      void set(@GuardSatisfied BitSet this, @GuardedBy int p0)
-      is not a valid method reference for method in @GuardedBy ObjIntConsumer&lt;@GuardedBy BitSet&gt;
-      void accept(@GuardedBy ObjIntConsumer&lt;@GuardedBy BitSet&gt; this, @GuardedBy BitSet p0, @GuardedBy int p1)
+      unsatisfiable constraint: @GuardedBy BitSet &lt;: @GuardSatisfied BitSet
     </details>
   </checkerFrameworkError>
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
-    <specifier>methodref.receiver</specifier>
-    <message>Incompatible receiver type</message>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for IntStream.collect</message>
     <lineContent>.collect(BitSet::new, BitSet::set, BitSet::or);</lineContent>
     <details>
-      found   : @GuardSatisfied BitSet
-      required: @GuardedBy BitSet
-      Consequence: method in @GuardedBy BitSet
-      void set(@GuardSatisfied BitSet this, @GuardedBy int p0)
-      is not a valid method reference for method in @GuardedBy ObjIntConsumer&lt;@GuardedBy BitSet&gt;
-      void accept(@GuardedBy ObjIntConsumer&lt;@GuardedBy BitSet&gt; this, @GuardedBy BitSet p0, @GuardedBy int p1)
+      unsatisfiable constraint: @GuardedBy BitSet &lt;: @GuardSatisfied BitSet
+    </details>
+  </checkerFrameworkError>
+
+  <checkerFrameworkError unstable="false">
+    <fileName>src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java</fileName>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.collect</message>
+    <lineContent>.collect(Collectors.toUnmodifiableMap(</lineContent>
+    <details>
+      unsatisfiable constraint: @GuardedBy Field &lt;: @GuardSatisfied Field
     </details>
   </checkerFrameworkError>
 </suppressedErrors>
diff --git a/config/checker-framework-suppressions/checker-methods-resource-fenum-suppressions.xml b/config/checker-framework-suppressions/checker-methods-resource-fenum-suppressions.xml
@@ -193,31 +193,21 @@
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/site/SiteUtil.java</fileName>
-    <specifier>methodref.param</specifier>
-    <message>Incompatible parameter type for obj</message>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.map</message>
     <lineContent>.map(Pattern.class::cast)</lineContent>
     <details>
-      found   : @FenumUnqualified Object
-      required: capture extends @FenumTop Object
-      Consequence: method in @FenumUnqualified Class&lt;@FenumUnqualified Pattern&gt;
-      @FenumUnqualified Pattern cast(@FenumUnqualified Class&lt;@FenumUnqualified Pattern&gt; this, @FenumUnqualified Object p0)
-      is not a valid method reference for method in @FenumUnqualified Function&lt;capture extends @FenumTop Object, @FenumUnqualified Pattern&gt;
-      @FenumUnqualified Pattern apply(@FenumUnqualified Function&lt;capture extends @FenumTop Object, @FenumUnqualified Pattern&gt; this, capture extends @FenumTop Object p0)
+      unsatisfiable constraint: capture extends @FenumTop Object &lt;: @FenumUnqualified Object
     </details>
   </checkerFrameworkError>
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/site/SiteUtil.java</fileName>
-    <specifier>methodref.param</specifier>
-    <message>Incompatible parameter type for obj</message>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.map</message>
     <lineContent>.map(String.class::cast)</lineContent>
     <details>
-      found   : @FenumUnqualified Object
-      required: capture extends @FenumTop Object
-      Consequence: method in @FenumUnqualified Class&lt;@FenumUnqualified String&gt;
-      @FenumUnqualified String cast(@FenumUnqualified Class&lt;@FenumUnqualified String&gt; this, @FenumUnqualified Object p0)
-      is not a valid method reference for method in @FenumUnqualified Function&lt;capture extends @FenumTop Object, @FenumUnqualified String&gt;
-      @FenumUnqualified String apply(@FenumUnqualified Function&lt;capture extends @FenumTop Object, @FenumUnqualified String&gt; this, capture extends @FenumTop Object p0)
+      unsatisfiable constraint: capture extends @FenumTop Object &lt;: @FenumUnqualified Object
     </details>
   </checkerFrameworkError>
 
@@ -234,16 +224,11 @@
 
   <checkerFrameworkError unstable="false">
     <fileName>src/main/java/com/puppycrawl/tools/checkstyle/utils/UnmodifiableCollectionUtil.java</fileName>
-    <specifier>methodref.param</specifier>
-    <message>Incompatible parameter type for obj</message>
+    <specifier>type.arguments.not.inferred</specifier>
+    <message>Could not infer type arguments for Stream.map</message>
     <lineContent>.map(elementType::cast)</lineContent>
     <details>
-      found   : @FenumUnqualified Object
-      required: S extends @FenumTop Object
-      Consequence: method in @FenumUnqualified Class&lt;T extends @FenumTop Object&gt;
-      T extends @FenumTop Object cast(@FenumUnqualified Class&lt;T extends @FenumTop Object&gt; this, @FenumUnqualified Object p0)
-      is not a valid method reference for method in @FenumUnqualified Function&lt;S extends @FenumTop Object, T extends @FenumTop Object&gt;
-      T extends @FenumTop Object apply(@FenumUnqualified Function&lt;S extends @FenumTop Object, T extends @FenumTop Object&gt; this, S extends @FenumTop Object p0)
+      unsatisfiable constraint: S extends @FenumTop Object &lt;: @FenumUnqualified Object
     </details>
   </checkerFrameworkError>