Issue #10548: Migrate to Inline Config Parser in InnerAssignmentCheck…

…Test
checkstyle · Aug 18, 2021 · 1b326d6 · 1b326d6
1 parent 0b64c4d
commit 1b326d6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -1760,7 +1760,6 @@
 
                 <exclude>**/SuppressWarningsHolderTest.class</exclude>
 
-                <exclude>**/InnerAssignmentCheckTest.class</exclude>
 
                 <exclude>**/LineCommentAtTheEndOfFileTest.class</exclude>
 

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java
@@ -61,16 +61,18 @@ public void testIt() throws Exception {
             "92:19: " + getCheckMessage(MSG_KEY),
             "181:22: " + getCheckMessage(MSG_KEY),
         };
-        verify(checkConfig, getPath("InputInnerAssignment.java"), expected);
+        verifyWithInlineConfigParser(checkConfig,
+                getPath("InputInnerAssignment.java"), expected);
     }
 
     @Test
     public void testLambdaExpression() throws Exception {
         final DefaultConfiguration checkConfig =
             createModuleConfig(InnerAssignmentCheck.class);
         final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
-        verify(checkConfig, getPath("InputInnerAssignmentLambdaExpressions.java"),
-            expected);
+        verifyWithInlineConfigParser(checkConfig,
+                getPath("InputInnerAssignmentLambdaExpressions.java"),
+                expected);
     }
 
     @Test

diff --git a/...s/com/puppycrawl/tools/checkstyle/checks/coding/innerassignment/InputInnerAssignment.java b/...s/com/puppycrawl/tools/checkstyle/checks/coding/innerassignment/InputInnerAssignment.java
@@ -19,7 +19,7 @@ void innerAssignments()
         int b;
         int c;
 
-        a = b = c = 1; // violation
+        a = b = c = 1; // 2 violations
 
         String s = Integer.toString(b = 2); // violation
 
@@ -47,8 +47,8 @@ public void demoBug1195047Comment3()
         if ((bb = false)) {} // violation
         for (int j = 0; (bb = false); j += 1) {} // violation
         while ((bb = false)) {} // violation
-        i = (bb = false) ? (b = 2) : (b += 1); // violation
-        i = (b += 1) + (b -= 1); // violation
+        i = (bb = false) ? (b = 2) : (b += 1); // 3 violations
+        i = (b += 1) + (b -= 1); // 2 violations
         do {i += 1;} while (bb = false); // violation
     }