Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADO pipeline plugin synchronous scan to have a retry number parameter to retry the connection to Checkmarx #61

Merged
merged 1 commit into from
May 22, 2024

Conversation

RahulPidde23
Copy link

@RahulPidde23 RahulPidde23 commented Apr 29, 2024

Changes
Added 2 configurable parameters waitTimeForRetryScan and scaWaitTimeForRetryScan for SAST and SCA. If user not added values by default it will take time 10 seconds for SAST and 5 second for SAST.

Test Cases
Note - We cannot reproduce errors so added a debug log to print parameter values

  1. Create new/use existing SAST project with Waiting Time Before Retry Scan In Seconds = blank
    Expected - It will take By default value 10 for SAST scan
    Check Debug Log - Waiting time before retry SAST scan is: 10
  2. Create new/use existing SAST project with Waiting Time Before Retry Scan In Seconds = invalid value Ex - abcd
    Expected - It will take By default value 10 for SAST scan
    Check Debug Log - Waiting time before retry SAST scan is: 10
  3. Create new/use existing SAST project with Waiting Time Before Retry Scan In Seconds = valid value Ex - 60
    Expected - It will take By default value 60 for SAST scan
    Check Debug Log - Waiting time before retry SAST scan is: 60
  4. Create new/use existing SCA project with Waiting Time Before Retry SCA Scan In Seconds = blank
    Expected - It will take By default value 5 for SCA scan
    Check Debug Log - Waiting time before retry SCA scan is: 5
  5. Create new/use existing SCA project with Waiting Time Before Retry SCA Scan In Seconds = invalid value Ex - abcd
    Expected - It will take By default value 5 for SCA scan
    Check Debug Log - Waiting time before retry SCA scan is: 5
  6. Create new/use existing SCA project with Waiting Time Before Retry SCA Scan In Seconds = valid value Ex - 60
    Expected - It will take By default value 60 for SCA scan
    Check Debug Log - Waiting time before retry SCA scan is: 60

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@ThokalSameer ThokalSameer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@RahulPidde23 RahulPidde23 merged commit be72cea into Q2_2024_Integration_Branch May 22, 2024
1 of 2 checks passed
@RahulPidde23 RahulPidde23 deleted the PLUG-1214 branch June 10, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants