Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getAnnotations function to plugin and remove _getState private one #892

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented May 22, 2023

This PR is adding getAnnotations function to annotation plugin to get all annotation elements created for a chart.
It also removes _getState` function from annotation plugin because it was used for testing and it was the only way to access to the elements instances.

TODO

  • test cases
  • types
  • documentation

@stockiNail stockiNail marked this pull request as draft May 22, 2023 15:57
@stockiNail stockiNail added this to the 3.1.0 milestone May 22, 2023
@stockiNail stockiNail changed the title add getAnnotation function to plugin and remove _getState private one add getAnnotations function to plugin and remove _getState private one May 22, 2023
@davidnir1
Copy link

Hello @stockiNail,
Is there an ETA on this PR (if approved)?
We're trying to prioritize tasks and this solves a big one for us :)
Thanks!

@stockiNail
Copy link
Collaborator Author

stockiNail commented Jun 13, 2023

Is there an ETA on this PR (if approved)?

@davidnir1 it's planned to be released in version 3.1.0 (next one if we will not have any bug in the meantime). There are other PRs tagged for 3.1.0 therefore additional time is needed but depends on the maintainer, we could also think to move some PRs to 3.2.0 and then try to release version 3.1.0 earlier.

@tomasbeloch
Copy link

Hello @stockiNail, is there some plan in place when you're planing to merge this one? It would be great to allow the tooltips over the box annotations. Thanks!

@stockiNail
Copy link
Collaborator Author

@tomasbeloch I don't think so, I'm a collaborator not a maintainer ;) Furthermore I'm currently busy in another important project therefore my time is very limited. I'm very sorry. I hope to have time soon to restart working on this project.
@kurkle what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants