Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] FitBoxes recursion when dimensions are NaN #7853

Merged
merged 2 commits into from Oct 9, 2020
Merged

[2.9] FitBoxes recursion when dimensions are NaN #7853

merged 2 commits into from Oct 9, 2020

Commits on Oct 8, 2020

  1. Infinite recursion when dimensions are NaN 

    Adding a verification on updateDims that handles a case when dimensions are both
NaN. This caused an infinite recursion on fitBoxes when calculating the layout
for a chart that is mounted on an element that is not yet in DOM.

Fixes chartjs#7761
    @alessandroasm
    alessandroasm committed Oct 8, 2020
    Copy the full SHA
    dce2063 View commit details
    Browse the repository at this point in the history

  2. Fixing lint errors

    @alessandroasm
    alessandroasm committed Oct 8, 2020
    Copy the full SHA
    ef43b7f View commit details
    Browse the repository at this point in the history