Generic registry for controllers, scales, elements and plugins #7435
Conversation
There was a problem hiding this comment.
I like the direction this is going. Looks like it includes #7412.
In terms of the changes of elements.Arc to elements.arc I kinda preferred the old version since they're classes. If we do make this change, we'll need to document it as a breaking change since these are publicly available.
Yes, I included #7412 to make things a bit easier (I'm assuming it gets merged)
I restored those to be capitalized. |
|
Looks like this needs a rebase @kurkle |
|
This looks pretty good to me. I can do a final pass after rebase |
|
Rebased. Had added a |
|
|
||
| const controllerDefaults = defaults[type]; | ||
| const ControllerClass = registry.getController(type); | ||
| Object.assign(ControllerClass.prototype, { |
There was a problem hiding this comment.
why can't we still set these in the controllers?
There was a problem hiding this comment.
So we don't pull the element types with the controller. So when you derive from a controller, you can change the element types and the original ones can be shaked.
This also enabled changing the element type only, for example:
Chart.register(MyBar);
Chart.defaults.bar.dataElementType = 'MyBar'`;
|
Needs another rebase @kurkle. |
|
Noticed that scale service was mentioned in couple of places still, while it does not exist any more. So updated those. |
* Generic registry for controllers, scales, elements and plugins * Remove references to scale service
Agrees with #7407 in many ways, only goes a lot further.
TODO:
defaults.scales.scale, and that would be another breaking change.Resolves: #7496