Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESM config file for Rollup #10564

Merged
merged 1 commit into from Aug 5, 2022
Merged

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 4, 2022

Unfortunately, can't convert the Karma config until Karma 7: karma-runner/karma#3679 (comment)

@etimberg etimberg merged commit e798def into chartjs:master Aug 5, 2022
@LeeLenaleee
Copy link
Collaborator

LeeLenaleee commented Aug 5, 2022

@benmccann the tests are currently failing because karma can't import the rollup config anymore, tried switching to dynamic imports that should work, but can't get it to work, can you take a look at it?

Edit:
Sorry for the mention, seems I finally found the thing I kept overlooking

Fix for failing tests is bundled with the removal of the deatroy hook in #10549

@benmccann benmccann deleted the rollup-esm branch August 5, 2022 13:45
@dangreen
Copy link
Collaborator

dangreen commented Aug 5, 2022

@kurkle @benmccann karma config imports rollup config, so now it can't be imported and CI falls with error

https://github.com/chartjs/Chart.js/runs/7690926110?check_suite_focus=true

I think need to revert this.

@benmccann
Copy link
Contributor Author

@dangreen see the comment just above yours: #10564 (comment). The fix is included in #10549. Hopefully we can merge that one soon

@kurkle
Copy link
Member

kurkle commented Aug 5, 2022

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants