Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go back to the list after disconnecting #52

Merged
merged 45 commits into from Apr 13, 2022
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 5, 2022

the idea is to be able to go back to the list after connecting and disconnecting from a remote.

this uses an unreleased version of bubbletea, which currently lives on its exec-reader branch

depends on charmbracelet/bubbletea#237
closes #49

This also exposes the item model.

closes #40

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
local already working, remote still a wip

the idea is to be able to go back to the list after connecting and disconnecting from a remote.

this uses an unreleased version of bubbletea, which currently lives on its exec-reader branch

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Apr 5, 2022
@caarlos0 caarlos0 changed the base branch from main to setitems April 5, 2022 13:03
@caarlos0 caarlos0 added the enhancement New feature or request label Apr 5, 2022
Base automatically changed from setitems to main April 6, 2022 13:14
@caarlos0 caarlos0 marked this pull request as ready for review April 6, 2022 13:14
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
This reverts commit f9f7b53.
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 merged commit e31fc2e into main Apr 13, 2022
@caarlos0 caarlos0 deleted the back-to-the-list branch April 13, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return back to wishlist after closing the connection
1 participant