Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: goroutine leak #79

Merged
merged 2 commits into from Oct 26, 2022
Merged

fix: goroutine leak #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5469fdc
fix: goroutine leak
caarlos0 Oct 24, 2022
1c09a5b
fix: why even an error channel
caarlos0 Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions bubbletea/tea.go
View file
Open in desktop
Expand Up @@ -67,7 +67,6 @@ func MiddlewareWithProgramHandler(bth ProgramHandler, cp termenv.Profile) wish.M
return func(sh ssh.Handler) ssh.Handler {
lipgloss.SetColorProfile(cp)
return func(s ssh.Session) {
errc := make(chan error, 1)
p := bth(s)
if p != nil {
_, windowChanges, _ := s.Pty()
Expand All @@ -77,19 +76,18 @@ func MiddlewareWithProgramHandler(bth ProgramHandler, cp termenv.Profile) wish.M
case <-s.Context().Done():
if p != nil {
p.Quit()
return
}
case w := <-windowChanges:
if p != nil {
p.Send(tea.WindowSizeMsg{Width: w.Width, Height: w.Height})
}
case err := <-errc:
if err != nil {
log.Print(err)
}
}
}
}()
errc <- p.Start()
if err := p.Start(); err != nil {
log.Print("app exit with error:", err)
}
// p.Kill() will force kill the program if it's still running,
// and restore the terminal to its original state in case of a
// tui crash
Expand Down