fix: replace newlines with crlf newlines #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when ssh requests a pty, lf newlines should be converted to crlf newlines. Ref: https://serverfault.com/a/593419
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 71.79% 72.33% +0.54%
==========================================
Files 18 18
Lines 897 911 +14
==========================================
+ Hits 644 659 +15
+ Misses 200 199 -1
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caarlos0
reviewed
Oct 18, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
|
one thing I just realized might be an issue: on windows, it will replace |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Merged
|
will be fixed in #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ssh requests a pty,
lfnewlines should be converted tocrlfnewlines.Ref: https://serverfault.com/a/593419