refactor: fix all linter issues #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
caarlos0
commented
Jan 17, 2022
| @@ -15,12 +15,12 @@ import ( | |||
| // start it with the tea.ProgramOptions returned. | |||
| // | |||
| // Deprecated: use Handler instead. | |||
| type BubbleTeaHandler func(ssh.Session) (tea.Model, []tea.ProgramOption) // nolint: revive | |||
| type BubbleTeaHandler = Handler // nolint: revive | |||
There was a problem hiding this comment.
just to make the deletion of this a 1 line change in the future :)
aymanbagabas
approved these changes
Jan 17, 2022
toby
approved these changes
Jan 17, 2022
muesli
reviewed
Jan 18, 2022
| @@ -147,10 +160,10 @@ func fatalGit(s ssh.Session, err error) { | |||
| msg := err.Error() | |||
| pktLine := fmt.Sprintf("%04x%s\n", len(msg)+5, msg) | |||
| _, _ = s.Write([]byte(pktLine)) | |||
| s.Exit(1) | |||
| s.Exit(1) // nolint: errcheck | |||
There was a problem hiding this comment.
Note: a slightly easier way to communicate we intentionally ignore a returned error in these situations, is following what we do in the line above:
_ = s.Exit(1)This also satisfies the linter. The same goes for srv.Close() below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes/ignores everything golangci-lint is complaining about.