Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename BubbleTeaHandler to Handler #26

Merged
merged 2 commits into from Jan 17, 2022
Merged

refactor: rename BubbleTeaHandler to Handler #26

merged 2 commits into from Jan 17, 2022

Conversation

caarlos0
Copy link
Member

this fixes a lint issue and also makes usage a bit nicer, instead of

bubbletea.BubbleTeaHandler()

you can use

bubbletea.Handler()

directly, which reads a bit less repetitive.

This change is backwards-compatible with previous versions. 馃檹

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jan 17, 2022
@caarlos0 caarlos0 requested a review from toby January 17, 2022 19:17
@caarlos0 caarlos0 self-assigned this Jan 17, 2022
Copy link
Contributor

@toby toby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 merged commit 1423c2d into main Jan 17, 2022
@caarlos0 caarlos0 deleted the handler branch January 17, 2022 19:18

// Middleware takes a BubbleTeaHandler and hooks the input and output for the
// Hander is the function Bubble Tea apps implement to hook into the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo Hander

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants