feat: support webp #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the8472
reviewed
Oct 28, 2022
video.go
Outdated
| opts.BackgroundColor, | ||
| ), | ||
| "-vcodec", "libwebp", | ||
| "-pix_fmt", "yuv420p", |
There was a problem hiding this comment.
4:2:0 chroma subsampling can be bad for sharp, high-contrast edges such as fonts.
There's a lossless version of webp, maybe that supports 4:4:4 chroma?
|
Is this PR blocked by something. How can we help to merge it |
|
@pauloxnet seems like it stalled on figuring out how to have ffmpeg generate a looping webp file, as well as on implementing the lossless feedback. |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
I pushed an update, it seems to work now, but some generated webp images feel laggy 🤔 I don't know much of ffmpeg (barely any ffmpeg tbh), if anyone knows whats wrong feel free to chime in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50
need to figure out how to loop webp, tried
-loop -1and it broke havok, will look more into it tomorrow...