Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestPlace for position.go #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add TestPlace for position.go #80

wants to merge 3 commits into from

Conversation

bashbunni
Copy link
Member

@bashbunni bashbunni commented Apr 11, 2022

Changes:

  • add test for Place from position.go

Upgrades:

  • increase test coverage for position.go from 0% to 70.91%

@maaslalani
Copy link
Member

@bashbunni I think this is good to merge, one thing I would recommend is removing the require dependency and simply using go == for string comparison.

@bashbunni
Copy link
Member Author

I'll rebase and fix the conflicts, then see if it still works 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants