refactor: replace props map with struct fields #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
who-needs-copy
branch
2 times, most recently
from
8c95fd7
to
7832119
Compare
aymanbagabas
force-pushed
the
who-needs-copy
branch
from
7832119
to
387f2d7
Compare
meowgorithm
approved these changes
May 1, 2024
meowgorithm
reviewed
May 1, 2024
Co-authored-by: Christian Rocha <christian@rocha.is>
maaslalani
approved these changes
May 1, 2024
|
Tested all of the bubbletea examples, looks good to me! |
caarlos0
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an int to store property existence and style struct fields to store the actual values for each non-bool property.
Fixes: #139
Fixes: #141