New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trees and lists #264
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
* `New()` now take no args * added a new `Root(string)` method * added a new `Items(...any)` method
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This is really cool! Ran all the examples on my machine and it looks rad 🥳 |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Hey Charm team, this is awesome. When can we expect it to land into master? That's exactly what we're missing. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Co-authored-by: bashbunni <15822994+bashbunni@users.noreply.github.com>
* chore(examples): go mod tidy * feat(tree): add rounded corner enumerator
Hey @testinfected we're still doing some usability tests on the API to decide if the developer experience is where we want it to be before release. No ETA yet, but the functionality is there, just want to make sure it's easy to use before publishing. We don't want to have to break the API in the future, so now's the time to get it all sorted :) |
Worked on top of @maaslalani trees and lists implementations, fixed some bugs, refactor some stuff, added a couple of possibilities (namely, sublists (as trees)), etc.
Its a big PR, but it if it makes it better, it closes this 4 other PRs:
closes #242
closes #240
closes #243
closes #263
Some examples: